Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(68)

Issue 1375733003: Reland of Blacklist GLVertexAttributesBench and GLVec4ScalarBench for GalaxyS4 due to skia:4373 (Closed)

Created:
5 years, 2 months ago by dogben
Modified:
5 years, 2 months ago
Reviewers:
joshualitt, borenet
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@bl-nanobench
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Reland of Blacklist GLVertexAttributesBench and GLVec4ScalarBench for GalaxyS4 due to skia:4373 (patchset #1 id:1 of https://codereview.chromium.org/1382933002/ ) Reason for revert: Not fixed. :-( Original issue's description: > Revert of Blacklist GLVertexAttributesBench and GLVec4ScalarBench for GalaxyS4 due to skia:4373 (patchset #1 id:1 of https://codereview.chromium.org/1365683003/ ) > > Reason for revert: > should hopefully be fixed, please reland if not. > > Original issue's description: > > Blacklist GLVertexAttributesBench and GLVec4ScalarBench for GalaxyS4 due to skia:4373 > > > > BUG=skia:4373 > > > > Committed: https://skia.googlesource.com/skia/+/3420d2796bad5ce553efb9909790ea72e578dc47 > > TBR=borenet@google.com,benjaminwagner@google.com > NOPRESUBMIT=true > NOTREECHECKS=true > NOTRY=true > BUG=skia:4373 > > Committed: https://skia.googlesource.com/skia/+/52f8deba607fd67558b57551cd43406c8b743072 TBR=borenet@google.com,joshualitt@google.com NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=skia:4373 Committed: https://skia.googlesource.com/skia/+/9442ab8a40dd0effde253e3b2d166bcf47222e92

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -1 line) Patch
M tools/nanobench_flags.json View 1 chunk +3 lines, -1 line 0 comments Download
M tools/nanobench_flags.py View 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
dogben
Created Reland of Blacklist GLVertexAttributesBench and GLVec4ScalarBench for GalaxyS4 due to skia:4373
5 years, 2 months ago (2015-10-01 23:25:41 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1375733003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1375733003/1
5 years, 2 months ago (2015-10-01 23:25:46 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1) as https://skia.googlesource.com/skia/+/9442ab8a40dd0effde253e3b2d166bcf47222e92
5 years, 2 months ago (2015-10-01 23:26:12 UTC) #3
joshualitt
5 years, 2 months ago (2015-10-02 13:56:13 UTC) #4
Message was sent while issue was closed.
A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/1385633002/ by joshualitt@google.com.

The reason for reverting is: Reverting, optimistically fixed.

Powered by Google App Engine
This is Rietveld 408576698