Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(178)

Issue 1375733002: Add old UrlFetcher.StringResponseSize histogram to histograms.xml. (Closed)

Created:
5 years, 2 months ago by mmenke
Modified:
5 years, 2 months ago
CC:
chromium-reviews, asvitkine+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Add old UrlFetcher.StringResponseSize histogram to histograms.xml. BUG=535601 Committed: https://crrev.com/32f7bac51e9d8c92464de0331f9156a8f91d946a Cr-Commit-Position: refs/heads/master@{#351193}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -0 lines) Patch
M tools/metrics/histograms/histograms.xml View 1 chunk +7 lines, -0 lines 0 comments Download

Messages

Total messages: 12 (2 generated)
mmenke
Was about to add a histogram to get this, and then noticed the old one, ...
5 years, 2 months ago (2015-09-28 20:27:35 UTC) #2
Alexei Svitkine (slow)
There's an unknowned version of this in the internal histograms.xml file: http://cs/chrome/histograms.xml Could you send ...
5 years, 2 months ago (2015-09-28 20:58:19 UTC) #3
mmenke
On 2015/09/28 20:58:19, Alexei Svitkine wrote: > There's an unknowned version of this in the ...
5 years, 2 months ago (2015-09-28 21:15:30 UTC) #4
Alexei Svitkine (slow)
On 2015/09/28 21:15:30, mmenke wrote: > On 2015/09/28 20:58:19, Alexei Svitkine wrote: > > There's ...
5 years, 2 months ago (2015-09-28 21:17:47 UTC) #5
mmenke
On 2015/09/28 21:15:30, mmenke wrote: > On 2015/09/28 20:58:19, Alexei Svitkine wrote: > > There's ...
5 years, 2 months ago (2015-09-28 21:17:49 UTC) #6
Alexei Svitkine (slow)
lgtm
5 years, 2 months ago (2015-09-28 21:28:13 UTC) #7
mmenke
On 2015/09/28 21:28:13, Alexei Svitkine wrote: > lgtm Thanks! And thanks for the help!
5 years, 2 months ago (2015-09-28 21:37:59 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1375733002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1375733002/1
5 years, 2 months ago (2015-09-28 21:38:58 UTC) #10
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 2 months ago (2015-09-28 22:52:54 UTC) #11
commit-bot: I haz the power
5 years, 2 months ago (2015-09-28 22:53:53 UTC) #12
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/32f7bac51e9d8c92464de0331f9156a8f91d946a
Cr-Commit-Position: refs/heads/master@{#351193}

Powered by Google App Engine
This is Rietveld 408576698