Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(26)

Side by Side Diff: build/common.gypi

Issue 137573003: Disable multithreading for gold (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 6 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 # Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 # Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 # Use of this source code is governed by a BSD-style license that can be 2 # Use of this source code is governed by a BSD-style license that can be
3 # found in the LICENSE file. 3 # found in the LICENSE file.
4 4
5 # IMPORTANT: 5 # IMPORTANT:
6 # Please don't directly include this file if you are building via gyp_chromium, 6 # Please don't directly include this file if you are building via gyp_chromium,
7 # since gyp_chromium is automatically forcing its inclusion. 7 # since gyp_chromium is automatically forcing its inclusion.
8 { 8 {
9 # Variables expected to be overriden on the GYP command line (-D) or by 9 # Variables expected to be overriden on the GYP command line (-D) or by
10 # ~/.gyp/include.gypi. 10 # ~/.gyp/include.gypi.
(...skipping 3559 matching lines...) Expand 10 before | Expand all | Expand 10 after
3570 }], 3570 }],
3571 ['linux_use_gold_flags==1', { 3571 ['linux_use_gold_flags==1', {
3572 'target_conditions': [ 3572 'target_conditions': [
3573 ['_toolset=="target"', { 3573 ['_toolset=="target"', {
3574 'ldflags': [ 3574 'ldflags': [
3575 # Experimentation found that using four linking threads 3575 # Experimentation found that using four linking threads
3576 # saved ~20% of link time. 3576 # saved ~20% of link time.
3577 # https://groups.google.com/a/chromium.org/group/chromium-dev/ browse_thread/thread/281527606915bb36 3577 # https://groups.google.com/a/chromium.org/group/chromium-dev/ browse_thread/thread/281527606915bb36
3578 # Only apply this to the target linker, since the host 3578 # Only apply this to the target linker, since the host
3579 # linker might not be gold, but isn't used much anyway. 3579 # linker might not be gold, but isn't used much anyway.
3580 '-Wl,--threads', 3580 # TODO(raymes): Disable threading because gold is frequently
3581 '-Wl,--thread-count=4', 3581 # crashing on the bots: crbug.com/161942.
3582 # '-Wl,--threads',
3583 # '-Wl,--thread-count=4',
3582 ], 3584 ],
3583 }], 3585 }],
3584 ], 3586 ],
3585 'conditions': [ 3587 'conditions': [
3586 ['release_valgrind_build==0', { 3588 ['release_valgrind_build==0', {
3587 'target_conditions': [ 3589 'target_conditions': [
3588 ['_toolset=="target"', { 3590 ['_toolset=="target"', {
3589 'ldflags': [ 3591 'ldflags': [
3590 # There seems to be a conflict of --icf and -pie 3592 # There seems to be a conflict of --icf and -pie
3591 # in gold which can generate crashy binaries. As 3593 # in gold which can generate crashy binaries. As
(...skipping 1204 matching lines...) Expand 10 before | Expand all | Expand 10 after
4796 # settings in target dicts. SYMROOT is a special case, because many other 4798 # settings in target dicts. SYMROOT is a special case, because many other
4797 # Xcode variables depend on it, including variables such as 4799 # Xcode variables depend on it, including variables such as
4798 # PROJECT_DERIVED_FILE_DIR. When a source group corresponding to something 4800 # PROJECT_DERIVED_FILE_DIR. When a source group corresponding to something
4799 # like PROJECT_DERIVED_FILE_DIR is added to a project, in order for the 4801 # like PROJECT_DERIVED_FILE_DIR is added to a project, in order for the
4800 # files to appear (when present) in the UI as actual files and not red 4802 # files to appear (when present) in the UI as actual files and not red
4801 # red "missing file" proxies, the correct path to PROJECT_DERIVED_FILE_DIR, 4803 # red "missing file" proxies, the correct path to PROJECT_DERIVED_FILE_DIR,
4802 # and therefore SYMROOT, needs to be set at the project level. 4804 # and therefore SYMROOT, needs to be set at the project level.
4803 'SYMROOT': '<(DEPTH)/xcodebuild', 4805 'SYMROOT': '<(DEPTH)/xcodebuild',
4804 }, 4806 },
4805 } 4807 }
OLDNEW
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698