Issue 137573002: win: Find and use toolchain installed by depot_tools

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 137573002: win: Find and use toolchain installed by depot_tools (Closed)

Created:
6 years, 11 months ago by scottmg

Modified:
6 years, 11 months ago

Reviewers:
Dirk Pranke

CC:
chromium-reviews, Mike Lawther (Google), halyavin2

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

win: Find and use toolchain installed by depot_tools The toolchain directory inside depot_tools will only exist if "set DEPOT_TOOLS_WIN_TOOLCHAIN=1" so this is currently a no-op. It will break the "dogfood" of 'GYP_MSVS_USE_SYSTEM_TOOLCHAIN' now renamed per above, but I think only a few people tested that (cc'd here). R=dpranke@chromium.org BUG=323300, 326357 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=245412