Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(55)

Issue 1375703003: Tune evacuation candidate selection. (Closed)

Created:
5 years, 2 months ago by ulan
Modified:
5 years, 2 months ago
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Tune evacuation candidate selection. This disables aggressive compaction for non-memory reducer GCs. BUG=chromium:502247 LOG=NO Committed: https://crrev.com/6d13610374247d796e85bc4548a3d7b33c7274f4 Cr-Commit-Position: refs/heads/master@{#31079}

Patch Set 1 #

Patch Set 2 : #

Total comments: 2

Patch Set 3 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -2 lines) Patch
M src/heap/mark-compact.cc View 1 2 1 chunk +1 line, -2 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
ulan
PTAL
5 years, 2 months ago (2015-10-01 14:30:36 UTC) #2
Hannes Payer (out of office)
lgtm https://codereview.chromium.org/1375703003/diff/20001/src/heap/mark-compact.cc File src/heap/mark-compact.cc (right): https://codereview.chromium.org/1375703003/diff/20001/src/heap/mark-compact.cc#newcode705 src/heap/mark-compact.cc:705: // The minimum about of memory to make ...
5 years, 2 months ago (2015-10-01 14:36:07 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1375703003/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1375703003/40001
5 years, 2 months ago (2015-10-02 14:02:26 UTC) #6
commit-bot: I haz the power
Committed patchset #3 (id:40001)
5 years, 2 months ago (2015-10-02 15:13:14 UTC) #7
commit-bot: I haz the power
5 years, 2 months ago (2015-10-02 15:13:23 UTC) #8
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/6d13610374247d796e85bc4548a3d7b33c7274f4
Cr-Commit-Position: refs/heads/master@{#31079}

Powered by Google App Engine
This is Rietveld 408576698