Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(411)

Issue 1375703002: Fire accessibility hover events when the touch exploration flag is set. (Closed)

Created:
5 years, 2 months ago by dmazzoni
Modified:
5 years, 2 months ago
CC:
aboxhall+watch_chromium.org, aboxhall, blink-reviews, blink-reviews-dom_chromium.org, chromium-reviews, darin-cc_chromium.org, dglazkov+blink, dmazzoni+watch_chromium.org, dmazzoni, dtseng+watch_chromium.org, eae+blinkwatch, jam, jdduke+watch_chromium.org, je_julie, mkwst+moarreviews-renderer_chromium.org, mlamouri+watch-content_chromium.org, nektarios, nektar+watch_chromium.org, plundblad+watch_chromium.org, rwlbuis, sof, tdresser+watch_chromium.org, yuzo+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fire accessibility hover events when the touch exploration flag is set. On Chrome OS, when spoken feedback is enabled we change the touch screen interaction model so that tapping or exploring the screen with one finger sends a mouse move event with a special touch accessibility flag set. This already fires the right accessibility events in 'views'. Finish hooking this up for native web accessibility by propagating the input event flag to Blink, and posting a 'hover' accessibility event on the target when that flag is set. BUG=513713 Committed: https://crrev.com/14b7078b451812e1c3745993e79ec1634047ea68 Cr-Commit-Position: refs/heads/master@{#351367}

Patch Set 1 #

Patch Set 2 : Offset by root window, not by screen #

Total comments: 4

Patch Set 3 : Use asserts instead of checks in test #

Unified diffs Side-by-side diffs Delta from patch set Stats (+157 lines, -0 lines) Patch
M components/test_runner/web_test_proxy.cc View 1 1 chunk +3 lines, -0 lines 0 comments Download
A content/browser/accessibility/touch_accessibility_aura_browsertest.cc View 1 2 1 chunk +107 lines, -0 lines 0 comments Download
M content/content_tests.gypi View 1 chunk +1 line, -0 lines 0 comments Download
M content/renderer/accessibility/blink_ax_enum_conversion.cc View 1 chunk +2 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/dom/AXObjectCache.h View 2 chunks +3 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/modules/accessibility/AXObjectCacheImpl.h View 1 chunk +2 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/modules/accessibility/AXObjectCacheImpl.cpp View 1 chunk +7 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/web/AssertMatchingEnums.cpp View 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/Source/web/WebViewImpl.cpp View 1 chunk +23 lines, -0 lines 0 comments Download
M third_party/WebKit/public/web/WebAXEnums.h View 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/public/web/WebInputEvent.h View 1 chunk +5 lines, -0 lines 0 comments Download
M ui/events/blink/blink_event_util.cc View 1 chunk +2 lines, -0 lines 0 comments Download

Depends on Patchset:

Messages

Total messages: 11 (3 generated)
dmazzoni
mkwst: all of the Blink code plundblad: content/browser/accessibility (the browser test) sadrul: ui/events/blink
5 years, 2 months ago (2015-09-28 19:24:14 UTC) #2
Mike West
Blink bits LGTM.
5 years, 2 months ago (2015-09-29 07:10:36 UTC) #3
Peter Lundblad
browsertest lgtm https://codereview.chromium.org/1375703002/diff/20001/content/browser/accessibility/touch_accessibility_aura_browsertest.cc File content/browser/accessibility/touch_accessibility_aura_browsertest.cc (right): https://codereview.chromium.org/1375703002/diff/20001/content/browser/accessibility/touch_accessibility_aura_browsertest.cc#newcode64 content/browser/accessibility/touch_accessibility_aura_browsertest.cc:64: CHECK(manager); nit: use ASSERT* in tests. https://codereview.chromium.org/1375703002/diff/20001/content/browser/accessibility/touch_accessibility_aura_browsertest.cc#newcode99 ...
5 years, 2 months ago (2015-09-29 09:48:14 UTC) #4
sadrul
lgtm
5 years, 2 months ago (2015-09-29 15:14:11 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1375703002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1375703002/40001
5 years, 2 months ago (2015-09-29 17:11:01 UTC) #8
dmazzoni
https://codereview.chromium.org/1375703002/diff/20001/content/browser/accessibility/touch_accessibility_aura_browsertest.cc File content/browser/accessibility/touch_accessibility_aura_browsertest.cc (right): https://codereview.chromium.org/1375703002/diff/20001/content/browser/accessibility/touch_accessibility_aura_browsertest.cc#newcode64 content/browser/accessibility/touch_accessibility_aura_browsertest.cc:64: CHECK(manager); On 2015/09/29 09:48:14, Peter Lundblad wrote: > nit: ...
5 years, 2 months ago (2015-09-29 17:11:28 UTC) #9
commit-bot: I haz the power
Committed patchset #3 (id:40001)
5 years, 2 months ago (2015-09-29 19:00:43 UTC) #10
commit-bot: I haz the power
5 years, 2 months ago (2015-09-29 19:01:55 UTC) #11
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/14b7078b451812e1c3745993e79ec1634047ea68
Cr-Commit-Position: refs/heads/master@{#351367}

Powered by Google App Engine
This is Rietveld 408576698