Add comments to SimpleSynchronousEntry callbacks.

net/disk_cache/simple/simple_synchronous_entry.h

Index: net/disk_cache/simple/simple_synchronous_entry.h
diff --git a/net/disk_cache/simple/simple_synchronous_entry.h b/net/disk_cache/simple/simple_synchronous_entry.h
index c47ba018b03c5b0b3bc9e1f4d1a3131fa4d81ae8..e7a6a27e31d24923d32a8183dc5d08ff009a3a4b 100644
--- a/net/disk_cache/simple/simple_synchronous_entry.h
+++ b/net/disk_cache/simple/simple_synchronous_entry.h
@@ -27,15 +27,20 @@ class IOBuffer;
 namespace disk_cache {
 
 // Worker thread interface to the very simple cache. This interface is not
-// thread safe, and callers must insure that it is only ever accessed from
+// thread safe, and callers must ensure that it is only ever accessed from
 // a single thread between synchronization points.
 class SimpleSynchronousEntry {
  public:
-  typedef base::Callback<void(SimpleSynchronousEntry*)>
+  // Callback type for the completion of creation of SimpleSynchronousEntry
+  // objects, for instance after OpenEntry() or CreateEntry(). |new_entry| is
+  // the newly created SimpleSynchronousEntry, constructed on the worker pool
+  // thread. |new_entry| == NULL in the case of error.
+  typedef base::Callback<void(SimpleSynchronousEntry* /* new_entry */)>

[rvargas (doing something else), 2013/04/08 22:49:44]

nit: any reason for not using the argument name without commenting it out?

[gavinp, 2013/04/09 17:51:17]

The reason is that cdecl v2.5 does not support named arguments in pointers to
functions, and I use it to test my pointer to function definitions. Thanks for
pointing this out, I'll do another upload shortly removing the comments.

       SynchronousCreationCallback;
 
-  typedef base::Callback<void(int)>
-      SynchronousOperationCallback;
+  // Callback type for IO operations on an entry not requiring special callback
+  // arguments (e.g. Write). |result| is a net::Error result code.
+  typedef base::Callback<void(int /* result */)> SynchronousOperationCallback;
 
   static void OpenEntry(
       const base::FilePath& path,