Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(300)

Unified Diff: net/disk_cache/simple/simple_synchronous_entry.h

Issue 13757005: Add comments to SimpleSynchronousEntry callbacks. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 7 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: net/disk_cache/simple/simple_synchronous_entry.h
diff --git a/net/disk_cache/simple/simple_synchronous_entry.h b/net/disk_cache/simple/simple_synchronous_entry.h
index c47ba018b03c5b0b3bc9e1f4d1a3131fa4d81ae8..082caeb050034fe23d235029c0fd069222fb4056 100644
--- a/net/disk_cache/simple/simple_synchronous_entry.h
+++ b/net/disk_cache/simple/simple_synchronous_entry.h
@@ -31,11 +31,16 @@ namespace disk_cache {
// a single thread between synchronization points.
class SimpleSynchronousEntry {
public:
- typedef base::Callback<void(SimpleSynchronousEntry*)>
+ // Callback type for the completion of creation of SimpleSynchronousEntry
+ // objects, for instance after OpenEntry() or CreateEntry(). |new_entry| is
+ // the newly created SimpleSynchronousEntry, constructed on the worker pool
+ // thread. |new_entry| == NULL in the case of error.
+ typedef base::Callback<void(SimpleSynchronousEntry* /* new_entry */)>
SynchronousCreationCallback;
- typedef base::Callback<void(int)>
- SynchronousOperationCallback;
+ // Callback type for IO operations on an entry not requiring special callback
+ // arguments (e.g. Write). |result| is a net::Error result code.
+ typedef base::Callback<void(int /* result */)> SynchronousOperationCallback;
static void OpenEntry(
const base::FilePath& path,
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698