Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(42)

Issue 1375683002: Clamp PerformanceResource and PerformanceTiming to 5us. (Closed)

Created:
5 years, 2 months ago by rmcilroy
Modified:
5 years, 2 months ago
Reviewers:
esprehn
CC:
chromium-reviews, igrigorik
Base URL:
https://chromium.googlesource.com/chromium/src.git@rIC_clamp
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Clamp PerformanceResource and PerformanceTiming to 5us. All DomHighResolutionTimes should be clamped to 5us. Do this for PerformanceResource and PerformanceTiming. BUG=506723 Committed: https://crrev.com/d07a1105b9dfb932278b54c66ca73ff1fce9453f Cr-Commit-Position: refs/heads/master@{#351277}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -2 lines) Patch
M third_party/WebKit/Source/core/timing/PerformanceResourceTiming.cpp View 2 chunks +2 lines, -1 line 0 comments Download
M third_party/WebKit/Source/core/timing/PerformanceTiming.cpp View 2 chunks +3 lines, -1 line 0 comments Download

Depends on Patchset:

Messages

Total messages: 13 (4 generated)
rmcilroy
Elliott, as discussed last week, this clamps the other DomHighResolutionTimes to 5us. No change was ...
5 years, 2 months ago (2015-09-28 17:37:18 UTC) #3
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1375683002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1375683002/1
5 years, 2 months ago (2015-09-28 17:38:02 UTC) #4
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
5 years, 2 months ago (2015-09-28 20:48:49 UTC) #6
esprehn
lgtm
5 years, 2 months ago (2015-09-28 22:55:37 UTC) #7
esprehn
On 2015/09/28 at 22:55:37, esprehn wrote: > lgtm We really need to centralize this though, ...
5 years, 2 months ago (2015-09-28 22:56:12 UTC) #8
rmcilroy
On 2015/09/28 22:56:12, esprehn wrote: > On 2015/09/28 at 22:55:37, esprehn wrote: > > lgtm ...
5 years, 2 months ago (2015-09-29 10:10:30 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1375683002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1375683002/1
5 years, 2 months ago (2015-09-29 10:10:40 UTC) #11
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 2 months ago (2015-09-29 10:16:02 UTC) #12
commit-bot: I haz the power
5 years, 2 months ago (2015-09-29 10:16:40 UTC) #13
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/d07a1105b9dfb932278b54c66ca73ff1fce9453f
Cr-Commit-Position: refs/heads/master@{#351277}

Powered by Google App Engine
This is Rietveld 408576698