third_party/WebKit/LayoutTests/fast/multicol/forced-break-before-complex-margin-collapsing.html - Issue 1375673004: Keep block pagination struts after layout, and store them before any type of break.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/LayoutTests/fast/multicol/forced-break-before-complex-margin-collapsing.html

Issue 1375673004: Keep block pagination struts after layout, and store them before any type of break. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 5 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/LayoutTests/fast/multicol/float-after-break-after-expected.html ('k') | third_party/WebKit/LayoutTests/fast/multicol/forced-break-before-complex-margin-collapsing-expected.txt » ('j') | third_party/WebKit/Source/core/layout/LayoutBlockFlow.cpp » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/LayoutTests/fast/multicol/forced-break-before-complex-margin-collapsing.html

diff --git a/third_party/WebKit/LayoutTests/fast/multicol/forced-break-before-complex-margin-collapsing.html b/third_party/WebKit/LayoutTests/fast/multicol/forced-break-before-complex-margin-collapsing.html

new file mode 100644

index 0000000000000000000000000000000000000000..e033dd22a11f2668c2f23d685c404f15b0ffa344

--- /dev/null

+++ b/third_party/WebKit/LayoutTests/fast/multicol/forced-break-before-complex-margin-collapsing.html

@@ -0,0 +1,24 @@

+<!DOCTYPE html>

+<script src="../../resources/check-layout.js"></script>

+<p>Given a parent block with a forced break before, and with an empty collapse-through child

+ followed by a child with a top margin, check that the parent block still ends up at the exact

+ top of the next column. The collapse-through child prevents us from correctly estimating the

+ logical top of the parent initially.</p>

+<p>Below there should be a yellow box. Inside it there should be a bottom-left aligned blue box and

+ a top-center aligned green box.</p>

+<div id="test" style="position:relative; -webkit-columns:3; -webkit-column-gap:10px; column-fill:auto; width:620px; height:90px; line-height:20px; background:yellow;">

+ <br>

+ <div style="padding-top:4px; background:blue;" data-offset-x="0" data-offset-y="60" data-expected-height="110">

+ <div style="-webkit-column-break-before:always; background:red;" data-offset-x="210" data-offset-y="0" data-expected-height="80">

+ <div data-offset-x="210" data-offset-y="0" data-expected-height="0"></div>

+ <div style="margin-top:50px; background:green;" data-offset-x="210" data-offset-y="0" data-expected-height="80">

+ <br><br><br><br>

+ </div>

+</div>

+<script>

+ checkLayout("#test");

+</script>