third_party/WebKit/LayoutTests/fast/multicol/unforced-break-after-complex-margin-collapsing.html - Issue 1375673004: Keep block pagination struts after layout, and store them before any type of break.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: third_party/WebKit/LayoutTests/fast/multicol/unforced-break-after-complex-margin-collapsing.html

Issue 1375673004: Keep block pagination struts after layout, and store them before any type of break. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 5 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« no previous file with comments | « third_party/WebKit/LayoutTests/fast/multicol/forced-break-before-complex-margin-collapsing-expected.txt ('k') | third_party/WebKit/LayoutTests/fast/multicol/unforced-break-after-complex-margin-collapsing-expected.txt » ('j') | third_party/WebKit/Source/core/layout/LayoutBlockFlow.cpp » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
(Empty)
	1 <!DOCTYPE html>

	2 <script src="../../resources/check-layout.js"></script>

	3 <p>Given a parent block with an empty collapse-through child followed by a child with a top margin,

	4 check that the parent block is pulled downwards by that margin, to the exact top of the next

	5 column. The collapse-through child prevents us from correctly estimating the logical top of the

	6 parent initially.</p>

	7 <p>Below there should be a yellow box. Inside it there should be a top-center al igned green box.</p>

	8 <div id="test" style="position:relative; -webkit-columns:3; -webkit-column-gap:1 0px; column-fill:auto; width:620px; height:90px; line-height:20px; background:ye llow;">

	9 <br>

	10 <br>

	11 <br>

	12 <br>

	13 <div style="background:red;" data-offset-x="210" data-offset-y="0" data-expe cted-height="80">

	14 <div data-offset-x="210" data-offset-y="0" data-expected-height="0"></di v>

	15 <div data-offset-x="210" data-offset-y="0" data-expected-height="80" sty le="margin-top:20px; background:green;">

	16 <br><br><br><br>

	17 </div>

	18 </div>

	19 </div>

	20 <script>

	21 checkLayout("#test");

	22 </script>

OLD	NEW