Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(777)

Issue 1375673002: Revert of Revert[2] of add ImageShader, sharing code with its Bitmap cousin (Closed)

Created:
5 years, 2 months ago by reed1
Modified:
5 years, 2 months ago
CC:
reviews_skia.org, bsalomon
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Revert of Revert[2] of add ImageShader, sharing code with its Bitmap cousin (patchset #11 id:200001 of https://codereview.chromium.org/1352293002/ ) Reason for revert: guess: Need to handle NPOT support in shader case Original issue's description: > Revert[2] of add ImageShader, sharing code with its Bitmap cousin > > Adjustment from previous land : runtime check for npot-support when texture is requested for tiling. > > (patchset #10 id:180001 of https://codereview.chromium.org/1342113002/ ) > > This reverts commit f2608513626264459a00388537175600b515cae2. > > BUG=skia:4365 > > Committed: https://skia.googlesource.com/skia/+/fe05707c356d2a8c2c69222591d4cafbd456b4e5 TBR=fmalita@chromium.org,robertphillips@google.com,bsalomon@google.com,reed@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=skia:4365 Committed: https://skia.googlesource.com/skia/+/476506d070dbc59b158acc1a00c34bff95ab2968

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+40 lines, -207 lines) Patch
M gyp/core.gypi View 1 chunk +0 lines, -2 lines 0 comments Download
M src/image/SkImage.cpp View 2 chunks +1 line, -2 lines 0 comments Download
D src/image/SkImageShader.h View 1 chunk +0 lines, -44 lines 0 comments Download
D src/image/SkImageShader.cpp View 1 chunk +0 lines, -144 lines 0 comments Download
M src/image/SkImage_Base.h View 1 chunk +4 lines, -1 line 0 comments Download
M src/image/SkImage_Generator.cpp View 2 chunks +16 lines, -0 lines 0 comments Download
M src/image/SkImage_Gpu.h View 1 chunk +3 lines, -0 lines 0 comments Download
M src/image/SkImage_Gpu.cpp View 3 chunks +7 lines, -14 lines 0 comments Download
M src/image/SkImage_Raster.cpp View 2 chunks +9 lines, -0 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
reed1
Created Revert of Revert[2] of add ImageShader, sharing code with its Bitmap cousin
5 years, 2 months ago (2015-09-28 17:26:35 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1375673002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1375673002/1
5 years, 2 months ago (2015-09-28 17:26:46 UTC) #2
commit-bot: I haz the power
5 years, 2 months ago (2015-09-28 17:26:54 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/476506d070dbc59b158acc1a00c34bff95ab2968

Powered by Google App Engine
This is Rietveld 408576698