Show GpuMemoryBuffer feature in chrome://gpu

content/browser/gpu/gpu_internals_ui.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "content/browser/gpu/gpu_internals_ui.h"
 
 #if defined(OS_LINUX) && defined(USE_X11)
 #include <X11/Xlib.h>
 #endif
 
 #include <string>
 
 #include "base/bind.h"
 #include "base/bind_helpers.h"
 #include "base/command_line.h"
 #include "base/environment.h"
 #include "base/i18n/time_formatting.h"
 #include "base/strings/string_number_conversions.h"
 #include "base/strings/stringprintf.h"
 #include "base/sys_info.h"
 #include "base/values.h"
+#include "content/browser/gpu/browser_gpu_memory_buffer_manager.h"
 #include "content/browser/gpu/compositor_util.h"
 #include "content/browser/gpu/gpu_data_manager_impl.h"
 #include "content/grit/content_resources.h"
 #include "content/public/browser/browser_thread.h"
 #include "content/public/browser/gpu_data_manager_observer.h"
 #include "content/public/browser/web_contents.h"
 #include "content/public/browser/web_ui.h"
 #include "content/public/browser/web_ui_data_source.h"
 #include "content/public/browser/web_ui_message_handler.h"
 #include "content/public/common/content_client.h"
@@ skipping 193 matching lines @@
 #if defined(OS_WIN)
   scoped_ptr<base::Value> dx_info = base::Value::CreateNullValue();
   if (gpu_info.dx_diagnostics.children.size())
     dx_info.reset(DxDiagNodeToList(gpu_info.dx_diagnostics));
   info->Set("diagnostics", dx_info.Pass());
 #endif
 
   return info;
 }
 
+const char* BufferFormatToString(gfx::BufferFormat format) {
+  switch (format) {
+    case gfx::BufferFormat::ATC:
+      return "ATC";
+    case gfx::BufferFormat::ATCIA:
+      return "ATCIA";
+    case gfx::BufferFormat::DXT1:
+      return "DXT1";
+    case gfx::BufferFormat::DXT5:
+      return "DXT5";
+    case gfx::BufferFormat::ETC1:
+      return "ETC1";
+    case gfx::BufferFormat::R_8:
+      return "R_8";
+    case gfx::BufferFormat::RGBA_4444:
+      return "RGBA_4444";
+    case gfx::BufferFormat::RGBX_8888:
+      return "RGBX_8888";
+    case gfx::BufferFormat::RGBA_8888:
+      return "RGBA_8888";
+    case gfx::BufferFormat::BGRX_8888:
+      return "BGRX_8888";
+    case gfx::BufferFormat::BGRA_8888:
+      return "BGRA_8888";
+    case gfx::BufferFormat::YUV_420:
+      return "YUV_420";
+    case gfx::BufferFormat::YUV_420_BIPLANAR:
+      return "YUV_420_BIPLANAR";
+    case gfx::BufferFormat::UYVY_422:
+      return "UYVY_422";
+  }
+  NOTREACHED();
+  return nullptr;
+}
+
+const char* BufferUsageToString(gfx::BufferUsage usage) {
+  switch (usage) {
+    case gfx::BufferUsage::GPU_READ:
+      return "GPU_READ";
+    case gfx::BufferUsage::GPU_READ_WRITE:
+      return "GPU_READ_WRITE";
+    case gfx::BufferUsage::GPU_READ_CPU_READ_WRITE:
+      return "GPU_READ_CPU_READ_WRITE";
+    case gfx::BufferUsage::GPU_READ_CPU_READ_WRITE_PERSISTENT:
+      return "GPU_READ_CPU_READ_WRITE_PERSISTENT";
+  }
+  NOTREACHED();
+  return nullptr;
+}
+
+base::DictionaryValue* GpuMemoryBufferInfoAsDictionaryValue() {
+  base::ListValue* gpu_memory_buffer_info = new base::ListValue();
+  gpu_memory_buffer_info->Append(
+      NewDescriptionValuePair("Formats", "Native usage support"));

[reveman, 2015/10/29 00:27:26]

I think it's a bit inappropriate to use a value pair row to describe the columns
below. I think it's better to just remove this row and maybe instead improve the
value pair strings for each format. See below.

[vignatti (out of this project), 2015/10/29 14:15:36]

Done.

+
+  BrowserGpuMemoryBufferManager* gpu_memory_buffer_manager =
+      BrowserGpuMemoryBufferManager::current();
+
+  for (size_t format = 0;
+       format < static_cast<size_t>(gfx::BufferFormat::LAST) + 1; format++) {
+    std::string native_usage_support;
+    for (size_t usage = 0;
+        usage < static_cast<size_t>(gfx::BufferUsage::LAST) + 1; usage++) {
+      if (gpu_memory_buffer_manager->IsNativeGpuMemoryBufferConfiguration(
+              static_cast<gfx::BufferFormat>(format),
+              static_cast<gfx::BufferUsage>(usage)))
+        native_usage_support =
+            base::StringPrintf("%s%s %s", native_usage_support.c_str(),
+                native_usage_support.empty() ? "" :",",
+                BufferUsageToString(static_cast<gfx::BufferUsage>(usage)));
+    }
+    if (native_usage_support.empty())
+      native_usage_support = base::StringPrintf("Unsupported");

[reveman, 2015/10/29 00:27:26]

Maybe "Software only" instead of "Unsupported" as that would implicitly make the
values represent what has native support. Leaving it as "Unsupported" is fine
with me too.

[vignatti (out of this project), 2015/10/29 14:15:36]

yup, let's use "Software only" then. Done.

+
+    gpu_memory_buffer_info->Append(NewDescriptionValuePair(
+        BufferFormatToString(static_cast<gfx::BufferFormat>(format)),
+        native_usage_support));
+  }
+
+  base::DictionaryValue* info = new base::DictionaryValue();
+  info->Set("gpu_memory_buffer_info", gpu_memory_buffer_info);
+
+  return info;
+}
+
 // This class receives javascript messages from the renderer.
 // Note that the WebUI infrastructure runs on the UI thread, therefore all of
 // this class's methods are expected to run on the UI thread.
 class GpuMessageHandler
     : public WebUIMessageHandler,
       public base::SupportsWeakPtr<GpuMessageHandler>,
       public GpuDataManagerObserver,
       public ui::GpuSwitchingObserver {
  public:
   GpuMessageHandler();
@@ skipping 157 matching lines @@
   feature_status->Set("problems", GetProblems());
   base::ListValue* workarounds = new base::ListValue();
   for (const std::string& workaround : GetDriverBugWorkarounds())
     workarounds->AppendString(workaround);
   feature_status->Set("workarounds", workarounds);
   gpu_info_val->Set("featureStatus", feature_status);
 
   // Send GPU Info to javascript.
   web_ui()->CallJavascriptFunction("browserBridge.onGpuInfoUpdate",
       *(gpu_info_val.get()));
+
+  // Get GpuMemoryBuffer Info.
+  scoped_ptr<base::DictionaryValue> gpu_memory_buffer_info_val(
+      GpuMemoryBufferInfoAsDictionaryValue());
+
+  // Send GpuMemoryBuffer Info to javascript.
+  web_ui()->CallJavascriptFunction("browserBridge.onGpuMemoryBufferInfoUpdate",
+      *(gpu_memory_buffer_info_val.get()));
 }
 
 void GpuMessageHandler::OnGpuSwitched() {
   GpuDataManagerImpl::GetInstance()->RequestCompleteGpuInfoIfNeeded();
 }
 
 }  // namespace
 
 
 ////////////////////////////////////////////////////////////////////////////////
 //
 // GpuInternalsUI
 //
 ////////////////////////////////////////////////////////////////////////////////
 
 GpuInternalsUI::GpuInternalsUI(WebUI* web_ui)
     : WebUIController(web_ui) {
   web_ui->AddMessageHandler(new GpuMessageHandler());
 
   // Set up the chrome://gpu/ source.
   BrowserContext* browser_context =
       web_ui->GetWebContents()->GetBrowserContext();
   WebUIDataSource::Add(browser_context, CreateGpuHTMLSource());
 }
 
 }  // namespace content