libaddressinput: Add fallback data for US address validation.

libaddressinput: Add fallback data for US address validation.

Useful in case the network is unavailable.

BUG=333399
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=245455

[Dan Beam, 2014-01-14 03:38:23]

lgtm

[Evan Stade, 2014-01-15 23:45:43]

ping rouslan

[please use gerrit instead, 2014-01-16 00:50:14]

Please re-upload with 'git cl upload --no-find-copies'. This will make it clear
that we're not trying to copy existing files.

https://codereview.chromium.org/137563004/diff/320001/third_party/libaddressi...
File third_party/libaddressinput/chromium/cpp/libaddressinput.gyp (right):

https://codereview.chromium.org/137563004/diff/320001/third_party/libaddressi...
third_party/libaddressinput/chromium/cpp/libaddressinput.gyp:62: 'target_name':
'unit_tests',
Please add 'test/fallback_data_store_test.cc' to this target.

https://codereview.chromium.org/137563004/diff/320001/third_party/libaddressi...
File third_party/libaddressinput/chromium/cpp/src/fallback_data_store.cc
(right):

https://codereview.chromium.org/137563004/diff/320001/third_party/libaddressi...
third_party/libaddressinput/chromium/cpp/src/fallback_data_store.cc:27:
"{\"data/US/LA\": {\"lang\": \"en\", \"zipex\": \"70000,71599\", \"nam"
Please specify where this data comes from, so that we can regenerate it in case
of updates.

https://codereview.chromium.org/137563004/diff/320001/third_party/libaddressi...
File third_party/libaddressinput/chromium/cpp/src/retriever.h (right):

https://codereview.chromium.org/137563004/diff/320001/third_party/libaddressi...
third_party/libaddressinput/chromium/cpp/src/retriever.h:60: const std::string&
downloaded_data);
The .cc file renamed the variable for the OnDownloaded() method below, not this
one.

https://codereview.chromium.org/137563004/diff/320001/third_party/libaddressi...
File third_party/libaddressinput/chromium/cpp/test/fallback_data_store_test.cc
(right):

https://codereview.chromium.org/137563004/diff/320001/third_party/libaddressi...
third_party/libaddressinput/chromium/cpp/test/fallback_data_store_test.cc:34:
EXPECT_TRUE(rule.ParseSerializedRule(data));
You should use Json::ParseObject() instead of Rule::ParseSerializedRule(),
because the |data| contains multiple rules. (Rule::ParseSerializedRule() expects
a single rule.)

https://codereview.chromium.org/137563004/diff/320001/third_party/libaddressi...
File third_party/libaddressinput/chromium/cpp/test/retriever_test.cc (right):

https://codereview.chromium.org/137563004/diff/320001/third_party/libaddressi...
third_party/libaddressinput/chromium/cpp/test/retriever_test.cc:134:
EXPECT_FALSE(data_.empty());
Aslo this:

EXPECT_NE(kEmptyData, data_);

(kEmptyData is "{}", which the FakeDownloader can sometimes return.)

[Evan Stade, 2014-01-16 01:09:10]

https://codereview.chromium.org/137563004/diff/320001/third_party/libaddressi...
File third_party/libaddressinput/chromium/cpp/libaddressinput.gyp (right):

https://codereview.chromium.org/137563004/diff/320001/third_party/libaddressi...
third_party/libaddressinput/chromium/cpp/libaddressinput.gyp:62: 'target_name':
'unit_tests',
On 2014/01/16 00:50:15, Rouslan Solomakhin wrote:
> Please add 'test/fallback_data_store_test.cc' to this target.

Done.

https://codereview.chromium.org/137563004/diff/320001/third_party/libaddressi...
File third_party/libaddressinput/chromium/cpp/src/fallback_data_store.cc
(right):

https://codereview.chromium.org/137563004/diff/320001/third_party/libaddressi...
third_party/libaddressinput/chromium/cpp/src/fallback_data_store.cc:27:
"{\"data/US/LA\": {\"lang\": \"en\", \"zipex\": \"70000,71599\", \"nam"
On 2014/01/16 00:50:15, Rouslan Solomakhin wrote:
> Please specify where this data comes from, so that we can regenerate it in
case
> of updates.

Done.

https://codereview.chromium.org/137563004/diff/320001/third_party/libaddressi...
File third_party/libaddressinput/chromium/cpp/src/retriever.h (right):

https://codereview.chromium.org/137563004/diff/320001/third_party/libaddressi...
third_party/libaddressinput/chromium/cpp/src/retriever.h:60: const std::string&
downloaded_data);
On 2014/01/16 00:50:15, Rouslan Solomakhin wrote:
> The .cc file renamed the variable for the OnDownloaded() method below, not
this
> one.

good catch, fixed.

https://codereview.chromium.org/137563004/diff/320001/third_party/libaddressi...
File third_party/libaddressinput/chromium/cpp/test/fallback_data_store_test.cc
(right):

https://codereview.chromium.org/137563004/diff/320001/third_party/libaddressi...
third_party/libaddressinput/chromium/cpp/test/fallback_data_store_test.cc:34:
EXPECT_TRUE(rule.ParseSerializedRule(data));
On 2014/01/16 00:50:15, Rouslan Solomakhin wrote:
> You should use Json::ParseObject() instead of Rule::ParseSerializedRule(),
> because the |data| contains multiple rules. (Rule::ParseSerializedRule()
expects
> a single rule.)

Done.

https://codereview.chromium.org/137563004/diff/320001/third_party/libaddressi...
File third_party/libaddressinput/chromium/cpp/test/retriever_test.cc (right):

https://codereview.chromium.org/137563004/diff/320001/third_party/libaddressi...
third_party/libaddressinput/chromium/cpp/test/retriever_test.cc:134:
EXPECT_FALSE(data_.empty());
On 2014/01/16 00:50:15, Rouslan Solomakhin wrote:
> Aslo this:
> 
> EXPECT_NE(kEmptyData, data_);
> 
> (kEmptyData is "{}", which the FakeDownloader can sometimes return.)

Done.

[please use gerrit instead, 2014-01-16 01:25:45]

Please run 'git cl upload --no-find-copies'.

https://codereview.chromium.org/137563004/diff/480002/third_party/libaddressi...
File third_party/libaddressinput/chromium/cpp/src/fallback_data_store.h (left):

https://codereview.chromium.org/137563004/diff/480002/third_party/libaddressi...
third_party/libaddressinput/chromium/cpp/src/fallback_data_store.h:15: #ifndef
I18N_ADDRESSINPUT_REGION_DATA_CONSTANTS_H_
Don't we need a header guard?

[please use gerrit instead, 2014-01-16 01:26:10]

Last review was nits. Other than that: lgtm.

[Evan Stade, 2014-01-16 01:53:54]

https://codereview.chromium.org/137563004/diff/480002/third_party/libaddressi...
File third_party/libaddressinput/chromium/cpp/src/fallback_data_store.h (left):

https://codereview.chromium.org/137563004/diff/480002/third_party/libaddressi...
third_party/libaddressinput/chromium/cpp/src/fallback_data_store.h:15: #ifndef
I18N_ADDRESSINPUT_REGION_DATA_CONSTANTS_H_
On 2014/01/16 01:25:46, Rouslan Solomakhin wrote:
> Don't we need a header guard?

yes we do, i simply forgot it.

[Evan Stade, 2014-01-16 02:00:18]

git cl upload --similarity=90 worked better.

[commit-bot: I haz the power, 2014-01-16 02:10:58]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/estade@chromium.org/137563004/550002

[commit-bot: I haz the power, 2014-01-16 03:22:57]

Retried try job too often on win_rel for step(s) base_unittests, browser_tests,
interactive_ui_tests, net_unittests, unit_tests
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_rel&nu...

[commit-bot: I haz the power, 2014-01-16 04:00:10]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/estade@chromium.org/137563004/550002

[commit-bot: I haz the power, 2014-01-16 05:49:54]

Retried try job too often on win_rel for step(s) base_unittests,
interactive_ui_tests
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_rel&nu...

[commit-bot: I haz the power, 2014-01-16 17:42:58]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/estade@chromium.org/137563004/380005

[commit-bot: I haz the power, 2014-01-16 18:07:11]

Retried try job too often on mac_rel for step(s) app_list_unittests,
cacheinvalidation_unittests, cc_unittests, check_deps, check_deps2git,
chromedriver_unittests, components_unittests, content_browsertests,
content_unittests, crypto_unittests, google_apis_unittests, gpu_unittests,
ipc_tests, jingle_unittests, media_unittests, message_center_unittests,
nacl_integration, ppapi_unittests, printing_unittests, remoting_unittests,
sql_unittests, sync_integration_tests, sync_unit_tests, telemetry_unittests
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=mac_rel&nu...

[commit-bot: I haz the power, 2014-01-16 20:00:31]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/estade@chromium.org/137563004/990002

[commit-bot: I haz the power, 2014-01-16 20:00:37]

Failed to apply patch for
third_party/libaddressinput/chromium/cpp/libaddressinput.gyp:
While running patch -p1 --forward --force --no-backup-if-mismatch;
  patching file third_party/libaddressinput/chromium/cpp/libaddressinput.gyp
  Hunk #1 FAILED at 37.
  Hunk #2 FAILED at 65.
  2 out of 2 hunks FAILED -- saving rejects to file
third_party/libaddressinput/chromium/cpp/libaddressinput.gyp.rej

Patch:       third_party/libaddressinput/chromium/cpp/libaddressinput.gyp
Index: third_party/libaddressinput/chromium/cpp/libaddressinput.gyp
diff --git a/third_party/libaddressinput/chromium/cpp/libaddressinput.gyp
b/third_party/libaddressinput/chromium/cpp/libaddressinput.gyp
index
a216634bc8672bf41ff0fb7f07acb8eb5aafa6df..da58a445e21dc4c4fe38b0453c5c38eadfe83851
100644
--- a/third_party/libaddressinput/chromium/cpp/libaddressinput.gyp
+++ b/third_party/libaddressinput/chromium/cpp/libaddressinput.gyp
@@ -37,6 +37,7 @@
         'src/address_ui.cc',
         'src/address_validator.cc',
         'src/country_rules_aggregator.cc',
+        'src/fallback_data_store.cc',
         'src/localization.cc',
         'src/region_data_constants.cc',
         'src/retriever.cc',
@@ -65,6 +66,7 @@
         'test/fake_downloader_test.cc',
         'test/fake_storage.cc',
         'test/fake_storage_test.cc',
+        'test/fallback_data_store_test.cc',
         'test/localization_test.cc',
         'test/region_data_constants_test.cc',
         'test/retriever_test.cc',

[commit-bot: I haz the power, 2014-01-16 21:49:11]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/estade@chromium.org/137563004/1080001

[commit-bot: I haz the power, 2014-01-17 07:00:51]

Change committed as 245455