Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(906)

Unified Diff: chrome/browser/ui/views/sync/one_click_signin_bubble_view.cc

Issue 137563002: OneClickSigninBubbleView: Only show title if no error present. [Mac+Views] (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Mac side changes. Created 6 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/views/sync/one_click_signin_bubble_view.cc
diff --git a/chrome/browser/ui/views/sync/one_click_signin_bubble_view.cc b/chrome/browser/ui/views/sync/one_click_signin_bubble_view.cc
index d96b497578ffe265fe63a9f6e49a790853559540..719d33d5de960d079d80a7328097b97a5c5ef01c 100644
--- a/chrome/browser/ui/views/sync/one_click_signin_bubble_view.cc
+++ b/chrome/browser/ui/views/sync/one_click_signin_bubble_view.cc
@@ -176,22 +176,24 @@ void OneClickSigninBubbleView::Init() {
void OneClickSigninBubbleView::InitBubbleContent(views::GridLayout* layout) {
layout->set_minimum_size(gfx::Size(kMinBubbleWidth, 0));
- // Add title message.
- views::ColumnSet* cs = layout->AddColumnSet(COLUMN_SET_TITLE_BAR);
- cs->AddColumn(views::GridLayout::LEADING, views::GridLayout::LEADING, 0,
- views::GridLayout::USE_PREF, 0, 0);
- {
- layout->StartRow(0, COLUMN_SET_TITLE_BAR);
+ // If no error occurred, add title message.
+ if (error_message_.empty()) {
+ views::ColumnSet* cs = layout->AddColumnSet(COLUMN_SET_TITLE_BAR);
+ cs->AddColumn(views::GridLayout::LEADING, views::GridLayout::LEADING, 0,
+ views::GridLayout::USE_PREF, 0, 0);
+ {
+ layout->StartRow(0, COLUMN_SET_TITLE_BAR);
+
+ views::Label* label = new views::Label(
+ l10n_util::GetStringUTF16(IDS_ONE_CLICK_SIGNIN_DIALOG_TITLE_NEW));
+ label->SetHorizontalAlignment(gfx::ALIGN_LEFT);
+ label->SetFont(label->font().DeriveFont(3));
+ layout->AddView(label);
+ }
- views::Label* label = new views::Label(
- l10n_util::GetStringUTF16(IDS_ONE_CLICK_SIGNIN_DIALOG_TITLE_NEW));
- label->SetHorizontalAlignment(gfx::ALIGN_LEFT);
- label->SetFont(label->font().DeriveFont(3));
- layout->AddView(label);
+ layout->AddPaddingRow(0, views::kUnrelatedControlLargeVerticalSpacing);
}
- layout->AddPaddingRow(0, views::kUnrelatedControlLargeVerticalSpacing);
-
// Add main text description.
layout->StartRow(0, COLUMN_SET_FILL_ALIGN);
@@ -280,7 +282,8 @@ void OneClickSigninBubbleView::InitButtons(views::GridLayout* layout) {
void OneClickSigninBubbleView::GetButtons(views::LabelButton** ok_button,
views::LabelButton** undo_button) {
- base::string16 ok_label =
+ base::string16 ok_label = !error_message_.empty() ?
+ l10n_util::GetStringUTF16(IDS_OK) :
l10n_util::GetStringUTF16(IDS_ONE_CLICK_SIGNIN_DIALOG_OK_BUTTON);
*ok_button = new views::LabelButton(this, ok_label);

Powered by Google App Engine
This is Rietveld 408576698