Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1337)

Issue 1375583003: Revert of [sql] Use memory-mapped I/O for sql::Connection. (Closed)

Created:
5 years, 2 months ago by zhaoqin1
Modified:
5 years, 2 months ago
CC:
chromium-reviews, tim+watch_chromium.org, pvalenzuela+watch_chromium.org, maxbogue+watch_chromium.org, plaree+watch_chromium.org, zea+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of [sql] Use memory-mapped I/O for sql::Connection. (patchset #3 id:40001 of https://codereview.chromium.org/1368533003/ ) Reason for revert: data race reported by TSan on sql/connection.cc BUG=537681 Original issue's description: > [sql] Use memory-mapped I/O for sql::Connection. > > sql::Connection::Open*() uses PRAGMA mmap_size to enable SQLite's > memory-mapped I/O. Additionally instrument to flush dirty pages from > the page cache after writes. > > [Relands https://crrev.com/9a1948a4d6d4, > reverted at https://crrev.com/55c3216b15ce ] > > BUG=489784, 533682 > > Committed: https://crrev.com/5c2f4e50d96d8b2ae0ae4a5c7d319e6be3b33bca > Cr-Commit-Position: refs/heads/master@{#351344} TBR=rmcilroy@chromium.org,pavely@chromium.org,shess@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=489784, 533682 Committed: https://crrev.com/745e18c523846de216c2f2253beb4e8047f77e57 Cr-Commit-Position: refs/heads/master@{#351596}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -216 lines) Patch
M sql/connection.h View 3 chunks +0 lines, -20 lines 0 comments Download
M sql/connection.cc View 6 chunks +0 lines, -94 lines 0 comments Download
M sql/connection_unittest.cc View 2 chunks +0 lines, -80 lines 0 comments Download
M sql/statement.cc View 1 chunk +0 lines, -5 lines 0 comments Download
M sync/syncable/directory_backing_store.cc View 1 chunk +0 lines, -4 lines 0 comments Download
M third_party/sqlite/BUILD.gn View 1 chunk +0 lines, -7 lines 0 comments Download
M third_party/sqlite/sqlite.gyp View 1 chunk +0 lines, -6 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
zhaoqin1
Created Revert of [sql] Use memory-mapped I/O for sql::Connection.
5 years, 2 months ago (2015-09-30 17:59:51 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1375583003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1375583003/1
5 years, 2 months ago (2015-09-30 18:00:47 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1375583003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1375583003/1
5 years, 2 months ago (2015-09-30 18:02:37 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 2 months ago (2015-09-30 18:04:37 UTC) #4
commit-bot: I haz the power
5 years, 2 months ago (2015-09-30 18:05:28 UTC) #5
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/745e18c523846de216c2f2253beb4e8047f77e57
Cr-Commit-Position: refs/heads/master@{#351596}

Powered by Google App Engine
This is Rietveld 408576698