Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(165)

Issue 1375573005: mac: Add CrashpadClient::UseSystemDefaultHandler() (Closed)

Created:
5 years, 2 months ago by Mark Mentovai
Modified:
5 years, 2 months ago
Reviewers:
Robert Sesek
CC:
crashpad-dev_chromium.org
Base URL:
https://chromium.googlesource.com/crashpad/crashpad@master
Target Ref:
refs/heads/master
Project:
crashpad
Visibility:
Public.

Description

mac: Add CrashpadClient::UseSystemDefaultHandler() Chrome’s relauncher process needs a way to sever ties with the crashpad_handler instance running from the disk image in order to cause that instance to exit so that the disk image may be unmounted. This new function is otherwise not thought to be interesting, and its use is not recommended. This comes with a small refactoring to create a SystemCrashReporterHandler() function, and a fix for a minor port leak in CrashReportExceptionHandler::CatchMachException(). BUG=chromium:538373 R=rsesek@chromium.org Committed: https://chromium.googlesource.com/crashpad/crashpad/+/cd85c9f700f7efda7ffa36e0017806a2263f4d08

Patch Set 1 #

Total comments: 1

Patch Set 2 : Address review feedback #

Unified diffs Side-by-side diffs Delta from patch set Stats (+119 lines, -56 lines) Patch
M client/crashpad_client.h View 1 chunk +24 lines, -0 lines 0 comments Download
M client/crashpad_client_mac.cc View 3 chunks +50 lines, -41 lines 0 comments Download
M handler/mac/crash_report_exception_handler.cc View 4 chunks +7 lines, -15 lines 0 comments Download
M util/mach/mach_extensions.h View 1 2 chunks +16 lines, -0 lines 0 comments Download
M util/mach/mach_extensions.cc View 1 2 chunks +16 lines, -0 lines 0 comments Download
M util/mach/mach_extensions_test.cc View 1 chunk +6 lines, -0 lines 0 comments Download

Messages

Total messages: 6 (1 generated)
Mark Mentovai
5 years, 2 months ago (2015-10-02 18:24:07 UTC) #2
Robert Sesek
https://codereview.chromium.org/1375573005/diff/1/util/mach/mach_extensions.h File util/mach/mach_extensions.h (right): https://codereview.chromium.org/1375573005/diff/1/util/mach/mach_extensions.h#newcode130 util/mach/mach_extensions.h:130: exception_handler_t SystemCrashReporterHandler(); I think this could return a ScopedMachSendRight, ...
5 years, 2 months ago (2015-10-02 18:30:19 UTC) #3
Mark Mentovai
I forgot that was based on ScopedGeneric. Updated.
5 years, 2 months ago (2015-10-02 18:38:21 UTC) #4
Robert Sesek
LGTM
5 years, 2 months ago (2015-10-02 18:39:11 UTC) #5
Mark Mentovai
5 years, 2 months ago (2015-10-02 18:41:07 UTC) #6
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as
cd85c9f700f7efda7ffa36e0017806a2263f4d08 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698