Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(431)

Issue 1375533002: Sync the RTCPeerConnection interface with the spec (Closed)

Created:
5 years, 2 months ago by philipj_slow
Modified:
5 years, 2 months ago
CC:
chromium-reviews, blink-reviews, tommyw+watchlist_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Patch Set 1 #

Patch Set 2 : TODO(philipj) -> TODO(guido) #

Total comments: 2

Patch Set 3 : fix username #

Unified diffs Side-by-side diffs Delta from patch set Stats (+84 lines, -34 lines) Patch
M third_party/WebKit/Source/modules/mediastream/RTCPeerConnection.h View 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/modules/mediastream/RTCPeerConnection.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/modules/mediastream/RTCPeerConnection.idl View 1 2 1 chunk +80 lines, -30 lines 0 comments Download

Messages

Total messages: 20 (4 generated)
philipj_slow
5 years, 2 months ago (2015-09-28 13:25:51 UTC) #2
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1375533002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1375533002/1
5 years, 2 months ago (2015-09-28 13:25:59 UTC) #3
philipj_slow
PTAL. The reason I'm doing this is https://groups.google.com/a/chromium.org/d/msg/blink-dev/9gq36Wl4Jwo/a8-rZOqCAgAJ where I want to figure out how ...
5 years, 2 months ago (2015-09-28 13:28:08 UTC) #4
tommi (sloooow) - chröme
Thanks Philip. - Harald: Can you take a look as well? - Guido, are you ...
5 years, 2 months ago (2015-09-28 14:41:45 UTC) #6
Guido Urdaneta
On 2015/09/28 14:41:45, tommi wrote: > Thanks Philip. > - Harald: Can you take a ...
5 years, 2 months ago (2015-09-28 14:46:46 UTC) #7
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
5 years, 2 months ago (2015-09-28 14:58:53 UTC) #9
philipj_slow
On 2015/09/28 14:46:46, Guido Urdaneta wrote: > On 2015/09/28 14:41:45, tommi wrote: > > Thanks ...
5 years, 2 months ago (2015-09-28 15:00:46 UTC) #10
Guido Urdaneta
https://codereview.chromium.org/1375533002/diff/20001/third_party/WebKit/Source/modules/mediastream/RTCPeerConnection.idl File third_party/WebKit/Source/modules/mediastream/RTCPeerConnection.idl (right): https://codereview.chromium.org/1375533002/diff/20001/third_party/WebKit/Source/modules/mediastream/RTCPeerConnection.idl#newcode60 third_party/WebKit/Source/modules/mediastream/RTCPeerConnection.idl:60: // TODO(guido): Many types are of the wrong type ...
5 years, 2 months ago (2015-09-29 11:43:49 UTC) #11
philipj_slow
https://codereview.chromium.org/1375533002/diff/20001/third_party/WebKit/Source/modules/mediastream/RTCPeerConnection.idl File third_party/WebKit/Source/modules/mediastream/RTCPeerConnection.idl (right): https://codereview.chromium.org/1375533002/diff/20001/third_party/WebKit/Source/modules/mediastream/RTCPeerConnection.idl#newcode60 third_party/WebKit/Source/modules/mediastream/RTCPeerConnection.idl:60: // TODO(guido): Many types are of the wrong type ...
5 years, 2 months ago (2015-09-29 12:04:14 UTC) #12
philipj_slow
Ping?
5 years, 2 months ago (2015-10-08 08:16:57 UTC) #13
Guido Urdaneta
On 2015/10/08 08:16:57, philipj wrote: > Ping? lgtm
5 years, 2 months ago (2015-10-08 08:35:55 UTC) #14
philipj_slow
tommi@, as the module owner, any concerns before landing?
5 years, 2 months ago (2015-10-08 09:05:39 UTC) #15
tommi (sloooow) - chröme
lgtm
5 years, 2 months ago (2015-10-08 12:41:16 UTC) #16
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1375533002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1375533002/40001
5 years, 2 months ago (2015-10-08 13:20:09 UTC) #18
commit-bot: I haz the power
Committed patchset #3 (id:40001)
5 years, 2 months ago (2015-10-08 14:24:17 UTC) #19
commit-bot: I haz the power
5 years, 2 months ago (2015-10-08 14:25:14 UTC) #20
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/c0174a877b6c866a36eed6e2c8d8b6effef94eeb
Cr-Commit-Position: refs/heads/master@{#353053}

Powered by Google App Engine
This is Rietveld 408576698