chrome/browser/chromeos/policy/policy_cert_verifier.cc - Issue 137553004: NSS Cros multiprofile: trust roots added by a profile shouldn't apply to other profiles.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/chromeos/policy/policy_cert_verifier.cc

Issue 137553004: NSS Cros multiprofile: trust roots added by a profile shouldn't apply to other profiles. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: expanded test, found one problem Created 6 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/chromeos/policy/policy_cert_verifier.h ('k') | chrome/browser/chromeos/policy/policy_cert_verifier_browsertest.cc » ('j') | net/cert/cert_verify_proc_chromeos.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/chromeos/policy/policy_cert_verifier.cc

diff --git a/chrome/browser/chromeos/policy/policy_cert_verifier.cc b/chrome/browser/chromeos/policy/policy_cert_verifier.cc

index 947f4dcca5bd22a740986eaeaa474097ed1c05bf..1c8d5f3c79663d65884e98f198f6c8e49a9be910 100644

--- a/chrome/browser/chromeos/policy/policy_cert_verifier.cc

+++ b/chrome/browser/chromeos/policy/policy_cert_verifier.cc

@@ -49,16 +49,15 @@ PolicyCertVerifier::~PolicyCertVerifier() {

DCHECK(content::BrowserThread::CurrentlyOn(content::BrowserThread::IO));

}

-void PolicyCertVerifier::InitializeOnIOThread() {

+void PolicyCertVerifier::InitializeOnIOThread(

+ const scoped_refptr<net::CertVerifyProc>& verify_proc) {

DCHECK(content::BrowserThread::CurrentlyOn(content::BrowserThread::IO));

- scoped_refptr<net::CertVerifyProc> verify_proc =

- net::CertVerifyProc::CreateDefault();

if (!verify_proc->SupportsAdditionalTrustAnchors()) {

LOG(WARNING)

<< "Additional trust anchors not supported on the current platform!";

}

net::MultiThreadedCertVerifier* verifier =

- new net::MultiThreadedCertVerifier(verify_proc.get());

+ new net::MultiThreadedCertVerifier(verify_proc);

verifier->SetCertTrustAnchorProvider(this);

delegate_.reset(verifier);

}