third_party/WebKit/Source/modules/nfc/NFCRecord.idl - Issue 1375483002: [webnfc] Step 2. Add IDL stubs for NFCRecord, NFCPushOptions, NFCWatchOptions

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: third_party/WebKit/Source/modules/nfc/NFCRecord.idl

Issue 1375483002: [webnfc] Step 2. Add IDL stubs for NFCRecord, NFCPushOptions, NFCWatchOptions (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: update idls to reflect changes in spec. Created 5 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« third_party/WebKit/Source/modules/nfc/NFCPushOptions.idl ('K') | « third_party/WebKit/Source/modules/nfc/NFCPushOptions.idl ('k') | third_party/WebKit/Source/modules/nfc/NFCWatchOptions.idl » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
(Empty)
	1 // Copyright 2015 The Chromium Authors. All rights reserved.

	2 // Use of this source code is governed by a BSD-style license that can be

	3 // found in the LICENSE file.

	4

	5 // https://w3c.github.io/web-nfc/index.html#the-nfcrecord-dictionary

	6

	7 enum NFCRecordType { "empty", "text", "url", "json", "opaque" };

	8

	9 [

	10 RuntimeEnabled=WebNFC,

	11 ] dictionary NFCRecord {

	12 NFCRecordType kind; // based on TNF + JSON.
	Peter Beverloo 2015/10/13 11:19:58 micro nit: comments such as this make the code a b micro nit: comments such as this make the code a bit convoluted - one can read the spec for this (and has to anyway, because I have no idea what TNF means).
	13 USVString type; // IANA media type, with parameters.

	14 // TODO(riju_): https://crbug.com/537133
	Peter Beverloo 2015/10/13 11:19:58 nit: Could you please include a textual descriptio nit: Could you please include a textual description with TODOs? The bug should be referred for additional context, but it should be understandable without following it.
	15 any data; // null, string (text, url), Object (json), ArrayBuffer.

	16 };

OLD	NEW