third_party/WebKit/Source/modules/nfc/NFCPushOptions.idl - Issue 1375483002: [webnfc] Step 2. Add IDL stubs for NFCRecord, NFCPushOptions, NFCWatchOptions

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: third_party/WebKit/Source/modules/nfc/NFCPushOptions.idl

Issue 1375483002: [webnfc] Step 2. Add IDL stubs for NFCRecord, NFCPushOptions, NFCWatchOptions (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: remove comment, add a note for blink idl bug. Created 5 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« no previous file with comments | « third_party/WebKit/Source/modules/modules.gypi ('k') | third_party/WebKit/Source/modules/nfc/NFCRecord.idl » ('j') | third_party/WebKit/Source/modules/nfc/NFCWatchOptions.idl » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
(Empty)
	1 // Copyright 2015 The Chromium Authors. All rights reserved.

	2 // Use of this source code is governed by a BSD-style license that can be

	3 // found in the LICENSE file.

	4

	5 // https://w3c.github.io/web-nfc/index.html#the-nfcpushoptions-dictionary

	6

	7 enum NFCPushTarget { "tag", "peer", "any" };
	Jeffrey Yasskin 2015/10/12 22:13:45 This doesn't match https://w3c.github.io/web-nfc/# This doesn't match https://w3c.github.io/web-nfc/#the-nfcpushoptions-dictionary anymore. riju_ 2015/10/13 10:51:56 Done. Show quoted text On 2015/10/12 22:13:45, jyasskin-OOO until Oct 30 wrote: > This doesn't match https://w3c.github.io/web-nfc/#the-nfcpushoptions-dictionary > anymore. Done.
	8

	9 [

	10 RuntimeEnabled=WebNFC,

	11 ] dictionary NFCPushOptions {

	12 NFCPushTarget target; // default "any".
	Jeffrey Yasskin 2015/10/12 22:13:45 It looks like the default's gone away too. It looks like the default's gone away too. riju_ 2015/10/13 10:51:56 Done. Show quoted text On 2015/10/12 22:13:45, jyasskin-OOO until Oct 30 wrote: > It looks like the default's gone away too. Done.
	13 unsigned long timeout;

	14 };

OLD	NEW