Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(214)

Issue 1375453002: Use EphemeralRange in makeSearchRange in VisibleSelection.cpp instead of Range object (Closed)

Created:
5 years, 2 months ago by yosin_UTC9
Modified:
5 years, 2 months ago
Reviewers:
yoichio
CC:
blink-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Use EphemeralRange in makeSearchRange in VisibleSelection.cpp instead of Range object This patch makes |makeSearchRange()| to use |EphemeralRange| instead of |Range| object to avoid registering temporary |Range| object into |Document| for Oilpan friendly and as a preparation of introducing full version of |VisibleSelectionTemplate|. This patch is a preparation of making selection to handle granularity for web component, http://crrev.com/1363873004 BUG=388681, 513568 TEST=n/a; no behavior changes Committed: https://crrev.com/4db8310fbdd01d9ef25cace80dbfab8350847796 Cr-Commit-Position: refs/heads/master@{#351045}

Patch Set 1 : 2015-09-28T15:19:43 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -19 lines) Patch
M third_party/WebKit/Source/core/editing/VisibleSelection.cpp View 1 chunk +9 lines, -19 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
yosin_UTC9
PTAL
5 years, 2 months ago (2015-09-28 06:41:17 UTC) #2
yoichio
lgtm
5 years, 2 months ago (2015-09-28 07:14:42 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1375453002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1375453002/1
5 years, 2 months ago (2015-09-28 07:29:43 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 2 months ago (2015-09-28 09:37:04 UTC) #6
commit-bot: I haz the power
5 years, 2 months ago (2015-09-28 09:38:27 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/4db8310fbdd01d9ef25cace80dbfab8350847796
Cr-Commit-Position: refs/heads/master@{#351045}

Powered by Google App Engine
This is Rietveld 408576698