Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1219)

Issue 137543006: Windows: only change default menu item if available. (Closed)

Created:
6 years, 11 months ago by mlamouri (slow - plz ping)
Modified:
6 years, 11 months ago
Reviewers:
sky
CC:
chromium-reviews, tfarina, chrome-apps-syd-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Visibility:
Public.

Description

Windows: only change default menu item if available. Some window can not be maximized. We should not make 'Maximize' the default menu item for them. BUG=333146 TEST=Open a window inside Chrome that can not be maximized, for example, the "Report an issue" window in "About Chrome". The menu in the title bar should not have "Maximize" in bold. Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=245072

Patch Set 1 #

Patch Set 2 : cleaner #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -1 line) Patch
M ui/views/win/hwnd_message_handler.cc View 1 1 chunk +4 lines, -1 line 0 comments Download

Messages

Total messages: 4 (0 generated)
mlamouri (slow - plz ping)
This cl should fix the regression but generally speaking HWNDMessageHandler::OnInitMenu needs some love ('Restore' is ...
6 years, 11 months ago (2014-01-14 03:31:41 UTC) #1
sky
LGTM
6 years, 11 months ago (2014-01-14 16:32:17 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/mlamouri@chromium.org/137543006/30001
6 years, 11 months ago (2014-01-15 03:43:23 UTC) #3
commit-bot: I haz the power
6 years, 11 months ago (2014-01-16 02:40:00 UTC) #4
Message was sent while issue was closed.
Change committed as 245072

Powered by Google App Engine
This is Rietveld 408576698