Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(521)

Issue 1375373002: [Interpreter] Fix cctest/test-bytecode-generator/IfConditions. (Closed)

Created:
5 years, 2 months ago by MTBrandyberry
Modified:
5 years, 2 months ago
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[Interpreter] Fix cctest/test-bytecode-generator/IfConditions. Avoid hard-coding expected parameter indices. These depend on the frame size which can vary (e.g. if embedded constant pools are enabled). R=oth@chromium.org, rmcilroy@chromium.org, michael_dawson@ca.ibm.com BUG= Committed: https://crrev.com/1ed17f20574b9bef0f6dfabfe4d53dc0f7c9fee6 Cr-Commit-Position: refs/heads/master@{#31049}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+25 lines, -25 lines) Patch
M test/cctest/interpreter/test-bytecode-generator.cc View 3 chunks +25 lines, -25 lines 0 comments Download

Messages

Total messages: 16 (5 generated)
MTBrandyberry
5 years, 2 months ago (2015-09-30 21:11:34 UTC) #1
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1375373002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1375373002/1
5 years, 2 months ago (2015-09-30 21:14:18 UTC) #3
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
5 years, 2 months ago (2015-09-30 21:36:10 UTC) #5
MTBrandyberry
This is the current cause of the PPC buildbot failure.
5 years, 2 months ago (2015-09-30 21:52:03 UTC) #6
oth
On 2015/09/30 21:52:03, mtbrandyberry wrote: > This is the current cause of the PPC buildbot ...
5 years, 2 months ago (2015-10-01 08:07:58 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1375373002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1375373002/1
5 years, 2 months ago (2015-10-01 13:20:17 UTC) #9
commit-bot: I haz the power
Try jobs failed on following builders: v8_presubmit on tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_presubmit/builds/6273)
5 years, 2 months ago (2015-10-01 13:22:59 UTC) #11
rmcilroy
On 2015/10/01 13:22:59, commit-bot: I haz the power wrote: > Try jobs failed on following ...
5 years, 2 months ago (2015-10-01 13:30:36 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1375373002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1375373002/1
5 years, 2 months ago (2015-10-01 13:30:49 UTC) #14
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 2 months ago (2015-10-01 13:33:17 UTC) #15
commit-bot: I haz the power
5 years, 2 months ago (2015-10-01 13:33:38 UTC) #16
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/1ed17f20574b9bef0f6dfabfe4d53dc0f7c9fee6
Cr-Commit-Position: refs/heads/master@{#31049}

Powered by Google App Engine
This is Rietveld 408576698