Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5)

Unified Diff: apply_issue.py

Issue 1375343005: apply_issue: catch all Rietveld flakiness failures. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/tools/depot_tools
Patch Set: Created 5 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: apply_issue.py
diff --git a/apply_issue.py b/apply_issue.py
index b4dbd7896d9175c1390b8bb583394bc4182a93d7..c2a85b1f3cd457b7f100d3e21f9785218b435bdb 100755
--- a/apply_issue.py
+++ b/apply_issue.py
@@ -203,9 +203,7 @@ def main():
print('Downloading patch from %s' % issue_url)
try:
patchset = obj.get_patch(issue_to_apply, patchset_to_apply)
- except urllib2.URLError:
- logging.exception('failed to fetch the patch for issue %d, patchset %d.',
- issue_to_apply, patchset_to_apply)
+ except urllib2.HTTPError:
print(
'Failed to fetch the patch for issue %d, patchset %d.\n'
'Try visiting %s/%d') % (
@@ -287,6 +285,10 @@ if __name__ == "__main__":
fix_encoding.fix_encoding()
try:
sys.exit(main())
+ except urllib2.URLError:
+ # Weird flakiness of GAE, see http://crbug.com/537417
+ logging.exception('failed to fetch something from Rietveld')
+ sys.exit(3)
except KeyboardInterrupt:
sys.stderr.write('interrupted\n')
sys.exit(1)
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698