MD Downloads: use <iron-list> to render download items

chrome/browser/resources/md_downloads/item.js

 // Copyright 2015 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 cr.define('downloads', function() {
   var Item = Polymer({
     is: 'downloads-item',
 
-    /**
-     * @param {!downloads.ThrottledIconLoader} iconLoader
-     */
-    factoryImpl: function(iconLoader) {
-      /** @private {!downloads.ThrottledIconLoader} */
-      this.iconLoader_ = iconLoader;
-    },
-
     properties: {
       data: {
         type: Object,
       },
 
       hideDate: {
         type: Boolean,
         value: true,
       },
 
-      readyPromise: {
-        type: Object,
-        value: function() {
-          return new Promise(function(resolve, reject) {
-            this.resolveReadyPromise_ = resolve;
-          }.bind(this));
-        },
-      },
-
       completelyOnDisk_: {
         computed: 'computeCompletelyOnDisk_(' +
             'data.state, data.file_externally_removed)',
         type: Boolean,
         value: true,
       },
 
       controlledBy_: {
         computed: 'computeControlledBy_(data.by_ext_id, data.by_ext_name)',
         type: String,
@@ skipping 52 matching lines @@
         computed: 'computeIsMalware_(isDangerous_, data.danger_type)',
         type: Boolean,
         value: false,
       },
     },
 
     observers: [
       // TODO(dbeam): this gets called way more when I observe data.by_ext_id
       // and data.by_ext_name directly. Why?
       'observeControlledBy_(controlledBy_)',
+      'observeIsDangerous_(isDangerous_, data.file_path)',

[esprehn, 2015/10/03 05:11:54]

So dangerous!

[Dan Beam, 2015/10/04 08:27:08]

Acknowledged.

     ],
 
     ready: function() {
       this.content = this.$.content;
-      this.resolveReadyPromise_();
-    },
-
-    /** @param {!downloads.Data} data */
-    update: function(data) {
-      this.data = data;
-
-      if (!this.isDangerous_) {
-        var icon = 'chrome://fileicon/' + encodeURIComponent(data.file_path);
-        this.iconLoader_.loadScaledIcon(this.$['file-icon'], icon);
-      }
     },
 
     /** @private */
     computeClass_: function() {
       var classes = [];
 
       if (this.isActive_)
         classes.push('is-active');
 
       if (this.isDangerous_)
@@ skipping 123 matching lines @@
     isIndeterminate_: function() {
       return this.data.percent == -1;
     },
 
     /** @private */
     observeControlledBy_: function() {
       this.$['controlled-by'].innerHTML = this.controlledBy_;
     },
 
     /** @private */
+    observeIsDangerous_: function() {
+      if (this.data && !this.isDangerous_) {
+        var filePath = encodeURIComponent(this.data.file_path);
+        this.$['file-icon'].src = 'chrome://fileicon/' + filePath;

[esprehn, 2015/10/03 05:11:54]

If we make our ids camel case this is prettier. Not for  this patch but
something to consider.

[Dan Beam, 2015/10/04 08:27:08]

Acknowledged.

+      }
+    },
+
+    /** @private */
     onCancelClick_: function() {
       downloads.ActionService.getInstance().cancel(this.data.id);
     },
 
     /** @private */
     onDiscardDangerous_: function() {
       downloads.ActionService.getInstance().discardDangerous(this.data.id);
     },
 
     /**
@@ skipping 40 matching lines @@
     },
 
     /** @private */
     onShowClick_: function() {
       downloads.ActionService.getInstance().show(this.data.id);
     },
   });
 
   return {Item: Item};
 });