Generalize "hide bookmark star" permission to "override bookmarks UI"

Generalize "hide bookmark star" permission to "override bookmarks UI"

Also, if the "bookmarks" permission is requested allow its permission
message to supersede the "override bookmarks UI" message, since the
former message was deemed to be sufficiently encompassing for changes
altering the bookmarks UI.

BUG=335655
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=245762

[not at google - send to devlin, 2014-01-18 00:36:44]

lgtm

https://codereview.chromium.org/137533013/diff/1/chrome/common/extensions/per...
File chrome/common/extensions/permissions/chrome_permission_message_provider.cc
(right):

https://codereview.chromium.org/137533013/diff/1/chrome/common/extensions/per...
chrome/common/extensions/permissions/chrome_permission_message_provider.cc:63:
PermissionMessages::const_iterator bookmarksPermission =
bookmarks_permission

https://codereview.chromium.org/137533013/diff/1/chrome/common/extensions/per...
chrome/common/extensions/permissions/chrome_permission_message_provider.cc:66:
PermissionMessages::const_iterator overrideBookmarksUI =
override_bookmarks_ui

https://codereview.chromium.org/137533013/diff/1/chrome/common/extensions/per...
chrome/common/extensions/permissions/chrome_permission_message_provider.cc:72:
overrideBookmarksUI != messages.end()) {
you can make this slightly more efficient by finding the override bookmarks UI
first, then inlining the bookmarks permission check. that would mean only
iterating over the permissions once in the common case.

// Special hack: bookmarks permission message...
PermissionMessages::const_iterator override_bookmarks_ui = ...;
if (override_bookmarks_ui != messages.end() &&
    FindMessageByID(messages, PermissionMessage::kBookmarks) !=
        messages.end()) {
  messages.erase(override_bookmarks_ui);
}

[Mike Wittman, 2014-01-18 00:49:33]

https://codereview.chromium.org/137533013/diff/1/chrome/common/extensions/per...
File chrome/common/extensions/permissions/chrome_permission_message_provider.cc
(right):

https://codereview.chromium.org/137533013/diff/1/chrome/common/extensions/per...
chrome/common/extensions/permissions/chrome_permission_message_provider.cc:63:
PermissionMessages::const_iterator bookmarksPermission =
On 2014/01/18 00:36:44, kalman wrote:
> bookmarks_permission

Removed.

https://codereview.chromium.org/137533013/diff/1/chrome/common/extensions/per...
chrome/common/extensions/permissions/chrome_permission_message_provider.cc:66:
PermissionMessages::const_iterator overrideBookmarksUI =
On 2014/01/18 00:36:44, kalman wrote:
> override_bookmarks_ui

Done.

https://codereview.chromium.org/137533013/diff/1/chrome/common/extensions/per...
chrome/common/extensions/permissions/chrome_permission_message_provider.cc:72:
overrideBookmarksUI != messages.end()) {
On 2014/01/18 00:36:44, kalman wrote:
> you can make this slightly more efficient by finding the override bookmarks UI
> first, then inlining the bookmarks permission check. that would mean only
> iterating over the permissions once in the common case.
> 
> // Special hack: bookmarks permission message...
> PermissionMessages::const_iterator override_bookmarks_ui = ...;
> if (override_bookmarks_ui != messages.end() &&
>     FindMessageByID(messages, PermissionMessage::kBookmarks) !=
>         messages.end()) {
>   messages.erase(override_bookmarks_ui);
> }

Done.

[commit-bot: I haz the power, 2014-01-18 00:50:41]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/wittman@chromium.org/137533013/60001

[commit-bot: I haz the power, 2014-01-18 01:10:36]

Retried try job too often on mac_rel for step(s) base_unittests, browser_tests,
interactive_ui_tests, net_unittests, unit_tests
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=mac_rel&nu...

[commit-bot: I haz the power, 2014-01-18 01:36:00]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/wittman@chromium.org/137533013/360001

[commit-bot: I haz the power, 2014-01-18 09:04:14]

Change committed as 245762