Issue 137533009: drive: Stop depending on order of search results from tests

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 137533009: drive: Stop depending on order of search results from tests (Closed)

Created:
6 years, 11 months ago by hashimoto

Modified:
6 years, 11 months ago

Reviewers:
kinaba

CC:
chromium-reviews, extensions-reviews_chromium.org, nkostylev+watch_chromium.org, tzik, tfarina, nhiroki, rginda+watch_chromium.org, oshima+watch_chromium.org, chromium-apps-reviews_chromium.org, kinuko+watch, stevenjb+watch_chromium.org, davemoore+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

drive: Stop depending on order of search results from tests BUG=None TEST=git cl try Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=245454

Patch Set 1 #

Created: 6 years, 11 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+51 lines, -76 lines)			Patch
	M	chrome/browser/chromeos/drive/file_system/search_operation_unittest.cc	View		5 chunks	+22 lines, -38 lines	0 comments	Download
	M	chrome/test/data/extensions/api_test/file_browser/drive_search_test/test.js	View		1 chunk	+29 lines, -38 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

kinaba

lgtm. Taking a look at the stop-DictionaryValue patch slowly... (sorry for my laziness)

6 years, 11 months ago (2014-01-16 08:26:07 UTC) #2

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/hashimoto@chromium.org/137533009/1

6 years, 11 months ago (2014-01-17 04:17:26 UTC) #3

Message was sent while issue was closed.

Change committed as 245454

Expand Messages | Collapse Messages