Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(159)

Unified Diff: services/files/util.h

Issue 1375313006: For c++, Generate enum classes instead of enum from mojom. (Closed) Base URL: https://github.com/domokit/mojo.git@master
Patch Set: Created 5 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « services/files/shared_impl.cc ('k') | services/files/util.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: services/files/util.h
diff --git a/services/files/util.h b/services/files/util.h
index 1575fcb6debf0a070135cc6babf1d2aeec062377..8e1e3e2f018b72979988d3fb996832710d37f0cc 100644
--- a/services/files/util.h
+++ b/services/files/util.h
@@ -14,21 +14,21 @@ class String;
namespace files {
// Validation functions (typically used to check arguments; they return
-// |ERROR_OK| if valid, else the standard/recommended error for the validation
+// |Error::OK| if valid, else the standard/recommended error for the validation
// error):
// Checks if |path|, which must be non-null, is (looks like) a valid (relative)
-// path. (On failure, returns |ERROR_INVALID_ARGUMENT| if |path| is not UTF-8,
-// or |ERROR_PERMISSION_DENIED| if it is not relative.)
+// path. (On failure, returns |Error::INVALID_ARGUMENT| if |path| is not UTF-8,
+// or |Error::PERMISSION_DENIED| if it is not relative.)
Error IsPathValid(const String& path);
// Checks if |whence| is a valid (known) |Whence| value. (On failure, returns
-// |ERROR_UNIMPLEMENTED|.)
+// |Error::UNIMPLEMENTED|.)
Error IsWhenceValid(Whence whence);
// Checks if |offset| is a valid file offset (from some point); this is
// implementation-dependent (typically checking if |offset| fits in an |off_t|).
-// (On failure, returns |ERROR_OUT_OF_RANGE|.)
+// (On failure, returns |Error::OUT_OF_RANGE|.)
Error IsOffsetValid(int64_t offset);
// Conversion functions:
« no previous file with comments | « services/files/shared_impl.cc ('k') | services/files/util.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698