mojo/public/tools/bindings/generators/cpp_templates/union_serialization_definition.tmpl - Issue 1375313006: For c++, Generate enum classes instead of enum from mojom.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: mojo/public/tools/bindings/generators/cpp_templates/union_serialization_definition.tmpl

Issue 1375313006: For c++, Generate enum classes instead of enum from mojom. (Closed) Base URL: https://github.com/domokit/mojo.git@master

Patch Set: Created 5 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « mojo/public/tools/bindings/generators/cpp_templates/struct_macros.tmpl ('k') | mojo/public/tools/bindings/generators/cpp_templates/wrapper_class_declaration.tmpl » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: mojo/public/tools/bindings/generators/cpp_templates/union_serialization_definition.tmpl

diff --git a/mojo/public/tools/bindings/generators/cpp_templates/union_serialization_definition.tmpl b/mojo/public/tools/bindings/generators/cpp_templates/union_serialization_definition.tmpl

index 53b212653eb646efc5ee95b399ae31658c29d959..4acbeb21b872aa2a89fe58382360177d3acdb4f3 100644

--- a/mojo/public/tools/bindings/generators/cpp_templates/union_serialization_definition.tmpl

+++ b/mojo/public/tools/bindings/generators/cpp_templates/union_serialization_definition.tmpl

@@ -78,6 +78,9 @@ void SerializeUnion_({{union.name}}* input, mojo::internal::Buffer* buf,

&result->data.f_{{field.name}});

mojo::internal::InterfacePointerToData(

input_acc.data()->{{field.name}}->Pass(), {{field.name}});

+{% elif field.kind|is_enum_kind %}

+ result->data.f_{{field.name}} =

+ static_cast<int32_t>(input_acc.data()->{{field.name}});

{% else %}

result->data.f_{{field.name}} = input_acc.data()->{{field.name}};

{%- endif %}

@@ -141,4 +144,4 @@ void Deserialize_(internal::{{union.name}}_Data* input,

break;

}