mojo/public/tools/bindings/generators/cpp_templates/interface_definition.tmpl - Issue 1375313006: For c++, Generate enum classes instead of enum from mojom.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: mojo/public/tools/bindings/generators/cpp_templates/interface_definition.tmpl

Issue 1375313006: For c++, Generate enum classes instead of enum from mojom. (Closed) Base URL: https://github.com/domokit/mojo.git@master

Patch Set: Created 5 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « mojo/public/tools/bindings/generators/cpp_templates/interface_declaration.tmpl ('k') | mojo/public/tools/bindings/generators/cpp_templates/module.cc.tmpl » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: mojo/public/tools/bindings/generators/cpp_templates/interface_definition.tmpl

diff --git a/mojo/public/tools/bindings/generators/cpp_templates/interface_definition.tmpl b/mojo/public/tools/bindings/generators/cpp_templates/interface_definition.tmpl

index 96e76621e6fda3c137104cb5d93ca465ff05829f..e4287045a11346b47880b50ff304e95cc243d774 100644

--- a/mojo/public/tools/bindings/generators/cpp_templates/interface_definition.tmpl

+++ b/mojo/public/tools/bindings/generators/cpp_templates/interface_definition.tmpl

@@ -1,6 +1,7 @@

{%- import "interface_macros.tmpl" as interface_macros %}

{%- import "struct_macros.tmpl" as struct_macros %}

{%- from "enum_macros.tmpl" import is_valid_enum_def %}

+{%- from "enum_macros.tmpl" import global_enum_operators_def %}

{%- set class_name = interface.name %}

{%- set proxy_name = interface.name ~ "Proxy" %}

@@ -44,7 +45,8 @@ MOJO_STATIC_CONST_MEMBER_DEFINITION const {{constant.kind|cpp_pod_type}} {{inter

{#--- Enums #}

{%- for enum in interface.enums %}

- {{is_valid_enum_def(enum, class_name=interface.name)|indent(2)}}

+ {{is_valid_enum_def(enum, class_name=interface.name)}}

+ {{global_enum_operators_def(enum, class_name=interface.name)}}

{%- endfor %}

{#--- ForwardToCallback definition #}