mojo/public/cpp/bindings/tests/request_response_unittest.cc - Issue 1375313006: For c++, Generate enum classes instead of enum from mojom.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: mojo/public/cpp/bindings/tests/request_response_unittest.cc

Issue 1375313006: For c++, Generate enum classes instead of enum from mojom. (Closed) Base URL: https://github.com/domokit/mojo.git@master

Patch Set: Created 5 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: mojo/public/cpp/bindings/tests/request_response_unittest.cc

diff --git a/mojo/public/cpp/bindings/tests/request_response_unittest.cc b/mojo/public/cpp/bindings/tests/request_response_unittest.cc

index 8bfeb5d543da7d0f4f306cb5c8b1c506313a345c..705f747e1a543bf36f2f4d412ee713aa27689509 100644

--- a/mojo/public/cpp/bindings/tests/request_response_unittest.cc

+++ b/mojo/public/cpp/bindings/tests/request_response_unittest.cc

@@ -140,11 +140,11 @@ TEST_F(RequestResponseTest, EchoEnum) {

ProviderImpl provider_impl(GetProxy(&provider));

sample::Enum value;

- provider->EchoEnum(sample::ENUM_VALUE, EnumRecorder(&value));

+ provider->EchoEnum(sample::Enum::VALUE, EnumRecorder(&value));

PumpMessages();

- EXPECT_EQ(sample::ENUM_VALUE, value);

+ EXPECT_EQ(sample::Enum::VALUE, value);

}

} // namespace