mojo/public/tools/bindings/generators/cpp_templates/struct_macros.tmpl - Issue 1375313006: For c++, Generate enum classes instead of enum from mojom.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: mojo/public/tools/bindings/generators/cpp_templates/struct_macros.tmpl

Issue 1375313006: For c++, Generate enum classes instead of enum from mojom. (Closed) Base URL: https://github.com/domokit/mojo.git@master

Patch Set: Created 5 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« mojo/public/tools/bindings/generators/cpp_templates/enum_macros.tmpl ('K') | « mojo/public/tools/bindings/generators/cpp_templates/module.h.tmpl ('k') | mojo/public/tools/bindings/generators/cpp_templates/union_serialization_definition.tmpl » ('j') | mojo/public/tools/bindings/generators/cpp_templates/union_serialization_definition.tmpl » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: mojo/public/tools/bindings/generators/cpp_templates/struct_macros.tmpl

diff --git a/mojo/public/tools/bindings/generators/cpp_templates/struct_macros.tmpl b/mojo/public/tools/bindings/generators/cpp_templates/struct_macros.tmpl

index 25a3ee414af454bf8aef95a1374abba0078c2364..9dd9e296984d54b3c1bc782c6385f4b3cbbed92c 100644

--- a/mojo/public/tools/bindings/generators/cpp_templates/struct_macros.tmpl

+++ b/mojo/public/tools/bindings/generators/cpp_templates/struct_macros.tmpl

@@ -95,6 +95,10 @@

mojo::internal::VALIDATION_ERROR_UNEXPECTED_INVALID_HANDLE,

"invalid {{name}} in {{struct_display_name}}");

{%- endif %}

+{%- elif kind|is_enum_kind %}

+ {{output}}->{{name}} =

+ static_cast<typename std::underlying_type<

viettrungluu 2015/10/01 17:49:55 Ditto -- no need for underlying_type.

johngro 2015/10/02 00:49:04 Done.

+ {{kind|cpp_wrapper_type}}>::type>({{input_field}});

{%- else %}

{{output}}->{{name}} = {{input_field}};

{%- endif %}