Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1047)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1375293003: Enable image is opaque test seems to pass now (Closed)

Created:
5 years, 2 months ago by joshua.litt
Modified:
5 years, 2 months ago
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Enable image is opaque test seems to pass now BUG=skia:2857 Committed: https://skia.googlesource.com/skia/+/4d06ae620de77f5570cff0624203c54b61fc9a34

Patch Set 1 #

Total comments: 1

Patch Set 2 : feedback inc #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -3 lines) Patch
M tests/ImageIsOpaqueTest.cpp View 1 1 chunk +1 line, -3 lines 0 comments Download

Messages

Total messages: 7 (3 generated)
joshualitt
ptal, trivial
5 years, 2 months ago (2015-10-01 16:37:06 UTC) #2
robertphillips
lgtm https://codereview.chromium.org/1375293003/diff/1/tests/ImageIsOpaqueTest.cpp File tests/ImageIsOpaqueTest.cpp (right): https://codereview.chromium.org/1375293003/diff/1/tests/ImageIsOpaqueTest.cpp#newcode90 tests/ImageIsOpaqueTest.cpp:90: rm the comment too ?
5 years, 2 months ago (2015-10-01 16:37:39 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1375293003/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1375293003/20001
5 years, 2 months ago (2015-10-01 16:43:03 UTC) #6
commit-bot: I haz the power
5 years, 2 months ago (2015-10-01 16:49:32 UTC) #7
Message was sent while issue was closed. 
Committed patchset #2 (id:20001) as
https://skia.googlesource.com/skia/+/4d06ae620de77f5570cff0624203c54b61fc9a34

Powered by Google App Engine
This is Rietveld 408576698