Fix completion of try..finally.

Fix completion of try..finally.

R=rossberg
BUG=v8:2529
LOG=Y

Committed: https://crrev.com/cf82eea6d744c3540bba7ff62b038034fdb79584
Cr-Commit-Position: refs/heads/master@{#31051}

[rossberg, 2015-10-01 09:59:24]

https://codereview.chromium.org/1375203004/diff/1/src/ast.h
File src/ast.h (right):

https://codereview.chromium.org/1375203004/diff/1/src/ast.h#newcode465
src/ast.h:465: void InsertStatementAt(int index, Statement* statement, Zone*
zone) {
Instead of adding yet another redundant helper, can we instead get rid of the
other?

https://codereview.chromium.org/1375203004/diff/1/src/rewriter.cc
File src/rewriter.cc (right):

https://codereview.chromium.org/1375203004/diff/1/src/rewriter.cc#newcode66
src/rewriter.cc:66: void BackupAndRestore(Block* b);
Nit: SaveAndRestore would sound more like the typical phrase. But in fact, I'd
just inline this function

[neis, 2015-10-01 10:56:49]

https://codereview.chromium.org/1375203004/diff/1/src/ast.h
File src/ast.h (right):

https://codereview.chromium.org/1375203004/diff/1/src/ast.h#newcode465
src/ast.h:465: void InsertStatementAt(int index, Statement* statement, Zone*
zone) {
On 2015/10/01 09:59:24, rossberg wrote:
> Instead of adding yet another redundant helper, can we instead get rid of the
> other?

Done.

https://codereview.chromium.org/1375203004/diff/1/src/rewriter.cc
File src/rewriter.cc (right):

https://codereview.chromium.org/1375203004/diff/1/src/rewriter.cc#newcode66
src/rewriter.cc:66: void BackupAndRestore(Block* b);
On 2015/10/01 09:59:24, rossberg wrote:
> Nit: SaveAndRestore would sound more like the typical phrase. But in fact, I'd
> just inline this function

Did that, but I don't think it improved readability.

[rossberg, 2015-10-01 10:58:44]

And of course I forgot the most important: please add regression tests.

[neis, 2015-10-01 11:23:07]

On 2015/10/01 10:58:44, rossberg wrote:
> And of course I forgot the most important: please add regression tests.

PTAL

[rossberg, 2015-10-01 11:29:36]

lgtm

[neis, 2015-10-01 11:57:30]

The CQ bit was checked by neis@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2015-10-01 11:57:36]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1375203004/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1375203004/40001

[commit-bot: I haz the power, 2015-10-01 12:13:12]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-10-01 12:13:13]

Dry run: Try jobs failed on following builders:
  v8_win64_rel on tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_win64_rel/builds/9192)

[neis, 2015-10-01 13:36:37]

The CQ bit was checked by neis@chromium.org

[neis, 2015-10-01 13:36:38]

The patchset sent to the CQ was uploaded after l-g-t-m from
rossberg@chromium.org
Link to the patchset: https://codereview.chromium.org/1375203004/#ps60001
(title: "Fix webkit test.")

[commit-bot: I haz the power, 2015-10-01 13:36:42]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1375203004/60001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1375203004/60001

[commit-bot: I haz the power, 2015-10-01 13:59:43]

Committed patchset #4 (id:60001)

[commit-bot: I haz the power, 2015-10-01 14:00:07]

Patchset 4 (id:??) landed as
https://crrev.com/cf82eea6d744c3540bba7ff62b038034fdb79584
Cr-Commit-Position: refs/heads/master@{#31051}

[adamk, 2015-10-05 17:39:28]

adamk@chromium.org changed reviewers:
+ adamk@chromium.org

[adamk, 2015-10-05 17:39:28]

https://codereview.chromium.org/1375203004/diff/60001/src/parser.cc
File src/parser.cc (right):

https://codereview.chromium.org/1375203004/diff/60001/src/parser.cc#newcode1936
src/parser.cc:1936: if (result) result->statements()->Add(statement, zone());
Looks like these were all changed in this patch (from AddStatement to
statements()->Add())? In future, please separate refactorings from functional
changes, it makes it much easier to follow the commit log.