Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(268)

Issue 1375193005: Clang update script: use the just-built Clang for building compiler-rt (Closed)

Created:
5 years, 2 months ago by hans
Modified:
5 years, 2 months ago
Reviewers:
Nico
CC:
chromium-reviews, eugenis+clang_chromium.org, glider+clang_chromium.org, dmikurube+clang_chromium.org, ukai+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Clang update script: use the just-built Clang for building compiler-rt After r248853, compiler-rt has problems building with the 10.10 SDK. Building with the just-built Clang should fix it. BUG=539600 TBR=thakis Committed: https://chromium.googlesource.com/chromium/src/+/b1324580f07ea08651002a05c7dc0471e53083db

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -3 lines) Patch
M tools/clang/scripts/update.sh View 1 chunk +3 lines, -3 lines 0 comments Download

Messages

Total messages: 8 (2 generated)
hans
This should hopefully fix the MacToT builders. They might need a manual clobbering of the ...
5 years, 2 months ago (2015-10-05 23:25:03 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1375193005/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1375193005/1
5 years, 2 months ago (2015-10-05 23:26:36 UTC) #4
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/b1324580f07ea08651002a05c7dc0471e53083db Cr-Commit-Position: refs/heads/master@{#352461}
5 years, 2 months ago (2015-10-05 23:30:13 UTC) #5
hans
Committed patchset #1 (id:1) manually as b1324580f07ea08651002a05c7dc0471e53083db (presubmit successful).
5 years, 2 months ago (2015-10-05 23:30:33 UTC) #6
Nico
lgtm Did you inform cbieneman that his change means that compiler-rt can't be built with ...
5 years, 2 months ago (2015-10-08 19:49:09 UTC) #7
hans
5 years, 2 months ago (2015-10-08 20:54:29 UTC) #8
Message was sent while issue was closed.
On 2015/10/08 19:49:09, Nico (offline until Fri Oct 9) wrote:
> Did you inform cbieneman that his change means that compiler-rt can't be built
> with Xcode's clang atm? Not sure if that's intentional. But for us, this is
> fine, thanks.

Yup. The reply was basically use a newer Clang.
http://lists.llvm.org/pipermail/llvm-commits/Week-of-Mon-20151005/303674.html

Powered by Google App Engine
This is Rietveld 408576698