third_party/WebKit/Source/core/style/GridResolvedPosition.h - Issue 1375173002: [css-grid] Unknown named grid lines on absolutely positioned items

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/style/GridResolvedPosition.h

Issue 1375173002: [css-grid] Unknown named grid lines on absolutely positioned items (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Patch for landing Created 5 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« third_party/WebKit/LayoutTests/fast/css-grid-layout/grid-positioned-items-unknown-named-grid-line.html ('K') | « third_party/WebKit/Source/core/layout/LayoutGrid.cpp ('k') | third_party/WebKit/Source/core/style/GridResolvedPosition.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/style/GridResolvedPosition.h

diff --git a/third_party/WebKit/Source/core/style/GridResolvedPosition.h b/third_party/WebKit/Source/core/style/GridResolvedPosition.h

index e35441fa95c437ab8181b1b97e5a4700acb4a50e..2991ed9d472453e56b07461c2bff165c9b53298c 100644

--- a/third_party/WebKit/Source/core/style/GridResolvedPosition.h

+++ b/third_party/WebKit/Source/core/style/GridResolvedPosition.h

@@ -45,6 +45,9 @@ public:

return GridResolvedPosition(resolvedPosition);

}

+ static bool isValidNamedLineOrArea(const String&, const ComputedStyle&, GridPositionSide);

esprehn 2015/10/01 08:43:28 add argument name for the string

Manuel Rego 2015/10/01 11:29:25 Acknowledged.

+ static GridPositionSide calculateInitialPositionSide(GridTrackSizingDirection);

esprehn 2015/10/01 08:43:28 remove calculate prefix

Manuel Rego 2015/10/01 11:29:25 Done.

+ static GridPositionSide calculateFinalPositionSide(GridTrackSizingDirection);

esprehn 2015/10/01 08:43:28 ditto

Manuel Rego 2015/10/01 11:29:25 Done.

static void initialAndFinalPositionsFromStyle(const ComputedStyle&, const LayoutBox&, GridTrackSizingDirection, GridPosition &initialPosition, GridPosition &finalPosition);

static GridSpan resolveGridPositionsFromAutoPlacementPosition(const ComputedStyle&, const LayoutBox&, GridTrackSizingDirection, const GridResolvedPosition&);

static PassOwnPtr<GridSpan> resolveGridPositionsFromStyle(const ComputedStyle&, const LayoutBox&, GridTrackSizingDirection);