Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(91)

Unified Diff: third_party/WebKit/Source/core/style/GridResolvedPosition.cpp

Issue 1375173002: [css-grid] Unknown named grid lines on absolutely positioned items (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/style/GridResolvedPosition.cpp
diff --git a/third_party/WebKit/Source/core/style/GridResolvedPosition.cpp b/third_party/WebKit/Source/core/style/GridResolvedPosition.cpp
index 87c0ac125ae35f5d7f97be644dc0df207b2ed09d..7519b5502d26917a2f5b4ba938b514246763cc26 100644
--- a/third_party/WebKit/Source/core/style/GridResolvedPosition.cpp
+++ b/third_party/WebKit/Source/core/style/GridResolvedPosition.cpp
@@ -20,19 +20,19 @@ static inline String implicitNamedGridLineForSide(const String& lineName, GridPo
return lineName + ((side == ColumnStartSide || side == RowStartSide) ? "-start" : "-end");
}
-static bool isValidNamedLineOrArea(const String& lineName, const ComputedStyle& style, GridPositionSide side)
+bool GridResolvedPosition::isValidNamedLineOrArea(const String& lineName, const ComputedStyle& style, GridPositionSide side)
{
const NamedGridLinesMap& gridLineNames = gridLinesForSide(style, side);
return gridLineNames.contains(implicitNamedGridLineForSide(lineName, side)) || gridLineNames.contains(lineName);
}
-static GridPositionSide calculateInitialPositionSide(GridTrackSizingDirection direction)
+GridPositionSide GridResolvedPosition::calculateInitialPositionSide(GridTrackSizingDirection direction)
{
return (direction == ForColumns) ? ColumnStartSide : RowStartSide;
}
-static GridPositionSide calculateFinalPositionSide(GridTrackSizingDirection direction)
+GridPositionSide GridResolvedPosition::calculateFinalPositionSide(GridTrackSizingDirection direction)
{
return (direction == ForColumns) ? ColumnEndSide : RowEndSide;
}

Powered by Google App Engine
This is Rietveld 408576698