Specification change for the 'libraryName' and 'partOfLibraryName' fields in Outline.

pkg/analysis_server/tool/spec/spec_input.html

Index: pkg/analysis_server/tool/spec/spec_input.html
diff --git a/pkg/analysis_server/tool/spec/spec_input.html b/pkg/analysis_server/tool/spec/spec_input.html
index c91301133bda9a0dc2e7a15e916024e6b5e44f1b..b2e45de9a8e6ec2e5b3fdf7776dd26c5901b59ff 100644
--- a/pkg/analysis_server/tool/spec/spec_input.html
+++ b/pkg/analysis_server/tool/spec/spec_input.html
@@ -1044,12 +1044,24 @@
               The file with which the outline is associated.
             </p>
           </field>
+          <field name="libraryName">
+            <ref>String</ref>
+            <p>
+              The name of the library defined by the file.

[Paul Berry, 2015/10/01 16:00:44]

We should clarify what happens if the file is the defining compilation unit of a
library, but the library is unnamed (i.e. there is neither a "library"
declaration nor a "part of" declaration).  Suggestion: in this case, libraryName
should be the empty string.

We should also clarify what happens if the file is a "part" file (i.e. it
contains a "part of" declaration).  Suggestion: in this case, libraryName should
be absent.  (And libraryName should be optional).

+            </p>
+          </field>
           <field name="outline">
             <ref>Outline</ref>
             <p>
               The outline associated with the file.
             </p>
           </field>
+          <field name="partOfLibraryName">

[Brian Wilkerson, 2015/10/01 16:13:00]

Do we need to differentiate between a library and a part? I agree with Paul that
both "libraryName" and "partOfLibraryName" should be optional because there will
either be one or the other but never both. But I have to ask: would it work to
have one optional field whose value is the name in the library directive if one
exists, the name in the part-of directive if one exists, and otherwise it is
omitted? Doing so wouldn't allow a client to know whether they're looking at a
library or a part, but I don't know whether that's useful. If it is, it might be
less confusing to add a "kind" field.

+            <ref>String</ref>
+            <p>
+              The name of the library the file in a part of.

[Paul Berry, 2015/10/01 16:00:44]

We should clarify what happens if the file is not a "part" file (i.e. it lacks a
"part of" declaration).  Suggestion: in this case, partOfLibraryName should be
absent.  (And partOfLibraryName should be optional).

We should also clarify what happens if another file references this file as a
part, but this file lacks a "part of" declaration.  (This is an error condition
but it could arise during editing).  Suggestion: in this case, partOfLibraryName
should be absent.

+            </p>
+          </field>
         </params>
       </notification>
       <notification event="overrides">