Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(226)

Issue 1375163002: Flex grow wrongly calculated for value between 0 and 1 (Closed)

Created:
5 years, 2 months ago by ashlin.j
Modified:
5 years, 2 months ago
Reviewers:
cbiesinger, harpreet.sk
CC:
chromium-reviews, szager+layoutwatch_chromium.org, zoltan1, blink-reviews-layout_chromium.org, pdr+renderingwatchlist_chromium.org, eae+blinkwatch, leviw+renderwatch, jchaffraix+rendering, blink-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Flex grow wrongly calculated for value between 0 and 1 When flex grow value for a flex item is set between 0 and 1, the extra space to flex for the flex item is wrongly calculated. If the value of totalFlexGrow is less than 1, then the available space would be totalFlexGrow times the available space. And then this space is distributed to all the flex items within the flex line. The spec describing it is: http://dev.w3.org/csswg/css-flexbox-1/#resolve-flexible-lengths... specifically this line "If the sum of the unfrozen flex items’ flex factors is less than one, multiply the initial free space by this sum." BUG=480752 Committed: https://crrev.com/5bdbe6de227d5408f9f289e99f405ebee46cc58f Cr-Commit-Position: refs/heads/master@{#351567}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+77 lines, -0 lines) Patch
A third_party/WebKit/LayoutTests/css3/flexbox/flex-grow-less-than-one.html View 1 chunk +74 lines, -0 lines 0 comments Download
A + third_party/WebKit/LayoutTests/css3/flexbox/flex-grow-less-than-one-expected.txt View 0 chunks +-1 lines, --1 lines 0 comments Download
M third_party/WebKit/Source/core/layout/LayoutFlexibleBox.cpp View 1 chunk +4 lines, -1 line 0 comments Download

Messages

Total messages: 8 (2 generated)
ashlin.j
5 years, 2 months ago (2015-09-30 09:40:45 UTC) #2
ashlin.j
This patch was reviewed at https://codereview.chromium.org/1314703006/. Had got a LGTM. Uploading the patch again from ...
5 years, 2 months ago (2015-09-30 09:44:40 UTC) #3
cbiesinger
lgtm
5 years, 2 months ago (2015-09-30 14:14:58 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1375163002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1375163002/1
5 years, 2 months ago (2015-09-30 14:16:35 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 2 months ago (2015-09-30 15:36:15 UTC) #7
commit-bot: I haz the power
5 years, 2 months ago (2015-09-30 15:37:17 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/5bdbe6de227d5408f9f289e99f405ebee46cc58f
Cr-Commit-Position: refs/heads/master@{#351567}

Powered by Google App Engine
This is Rietveld 408576698