Dynamically allocate the GrDrawContexts

Dynamically allocate the GrDrawContexts

This CL moves the allocation and storage of the GrTextContexts into the DrawingManager. The GrDrawContexts now just get their GrTextContext from the DrawingManager.

Committed: https://skia.googlesource.com/skia/+/2d70dcbe5cf4b1d26bb03070d4f8cffd756dd509

[robertphillips, 2015-10-05 20:39:14]

robertphillips@google.com changed reviewers:
+ bsalomon@google.com

[bsalomon, 2015-10-06 13:42:42]

https://codereview.chromium.org/1375153007/diff/60001/include/gpu/GrContext.h
File include/gpu/GrContext.h (right):

https://codereview.chromium.org/1375153007/diff/60001/include/gpu/GrContext.h...
include/gpu/GrContext.h:186: GrTextContext* textContext(const SkSurfaceProps&
surfaceProps, GrRenderTarget* rt) {
Should we be using the GrContext to get the text context or should it come from
the draw context?
Otherwise, lgtm

[robertphillips, 2015-10-06 13:50:58]

https://codereview.chromium.org/1375153007/diff/60001/include/gpu/GrContext.h
File include/gpu/GrContext.h (right):

https://codereview.chromium.org/1375153007/diff/60001/include/gpu/GrContext.h...
include/gpu/GrContext.h:186: GrTextContext* textContext(const SkSurfaceProps&
surfaceProps, GrRenderTarget* rt) {
On 2015/10/06 13:42:42, bsalomon wrote:
> Should we be using the GrContext to get the text context or should it come
from
> the draw context?
> Otherwise, lgtm

draw contexts come and go now so the text contexts can't hang out there. I have
the DrawingMgr holding onto them right now - which seems right but, currently,
the draw contexts only have a back pointer to the context. I could friend
DrawContext from GrContext and hide the 'textContext' entry point but that gives
the draw context a lot of access.

[robertphillips, 2015-10-06 14:00:17]

The CQ bit was checked by robertphillips@google.com to run a CQ dry run

[commit-bot: I haz the power, 2015-10-06 14:00:25]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1375153007/60001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1375153007/60001

[commit-bot: I haz the power, 2015-10-06 14:06:46]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-10-06 14:06:47]

Dry run: This issue passed the CQ dry run.

[robertphillips, 2015-10-06 14:37:42]

The CQ bit was checked by robertphillips@google.com

[commit-bot: I haz the power, 2015-10-06 14:37:49]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1375153007/60001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1375153007/60001

[commit-bot: I haz the power, 2015-10-06 14:38:27]

Committed patchset #4 (id:60001) as
https://skia.googlesource.com/skia/+/2d70dcbe5cf4b1d26bb03070d4f8cffd756dd509