Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(233)

Issue 1375153006: Implement DOM: prepend, append, before, after & replaceWith (Closed)

Created:
5 years, 2 months ago by Paritosh Kumar
Modified:
4 years, 7 months ago
Reviewers:
philipj_slow
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Implement DOM: prepend, append, before, after & replaceWith This is a copy of https://codereview.chromium.org/1085843002/. BUG=255482

Patch Set 1 #

Total comments: 1

Patch Set 2 : #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+789 lines, -7 lines) Patch
A third_party/WebKit/LayoutTests/fast/dom/ChildNode/after.html View 1 chunk +135 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/fast/dom/ChildNode/before.html View 1 chunk +135 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/fast/dom/ChildNode/replace-with.html View 1 chunk +120 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/fast/dom/ParentNode/append.html View 1 chunk +73 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/fast/dom/ParentNode/append-on-document.html View 1 chunk +50 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/fast/dom/ParentNode/prepend.html View 1 chunk +73 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/fast/dom/ParentNode/prepend-on-document.html View 1 chunk +50 lines, -0 lines 0 comments Download
M third_party/WebKit/LayoutTests/webexposed/element-instance-property-listing-expected.txt View 6 chunks +10 lines, -0 lines 0 comments Download
M third_party/WebKit/LayoutTests/webexposed/global-interface-listing-expected.txt View 6 chunks +15 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/dom/ChildNode.h View 1 chunk +15 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/dom/ChildNode.idl View 1 chunk +4 lines, -5 lines 0 comments Download
M third_party/WebKit/Source/core/dom/Node.h View 2 chunks +6 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/dom/Node.cpp View 1 1 chunk +90 lines, -0 lines 1 comment Download
M third_party/WebKit/Source/core/dom/ParentNode.h View 1 chunk +10 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/dom/ParentNode.idl View 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/platform/RuntimeEnabledFeatures.in View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 6 (1 generated)
philipj_slow
https://codereview.chromium.org/1375153006/diff/1/third_party/WebKit/Source/core/dom/Node.cpp File third_party/WebKit/Source/core/dom/Node.cpp (right): https://codereview.chromium.org/1375153006/diff/1/third_party/WebKit/Source/core/dom/Node.cpp#newcode569 third_party/WebKit/Source/core/dom/Node.cpp:569: Node* viableNextSibling = findViableNextSibling(*this, nodes); viableNextSibling may not survive ...
5 years, 2 months ago (2015-10-06 11:16:16 UTC) #2
Stepien Nicolas
On 2015/10/06 11:16:16, philipj wrote: > https://codereview.chromium.org/1375153006/diff/1/third_party/WebKit/Source/core/dom/Node.cpp > File third_party/WebKit/Source/core/dom/Node.cpp (right): > > https://codereview.chromium.org/1375153006/diff/1/third_party/WebKit/Source/core/dom/Node.cpp#newcode569 > ...
5 years, 2 months ago (2015-10-08 14:04:39 UTC) #3
philipj_slow
On 2015/10/08 14:04:39, Stepien Nicolas wrote: > On 2015/10/06 11:16:16, philipj wrote: > > > ...
5 years, 2 months ago (2015-10-08 14:19:27 UTC) #4
philipj_slow
Please ignore if it's a WIP. https://codereview.chromium.org/1375153006/diff/20001/third_party/WebKit/Source/core/dom/Node.cpp File third_party/WebKit/Source/core/dom/Node.cpp (right): https://codereview.chromium.org/1375153006/diff/20001/third_party/WebKit/Source/core/dom/Node.cpp#newcode535 third_party/WebKit/Source/core/dom/Node.cpp:535: insertBefore(node.release(), firstChild(), exceptionState); ...
5 years, 2 months ago (2015-10-08 14:19:38 UTC) #5
Paritosh Kumar
4 years, 7 months ago (2016-05-06 11:12:12 UTC) #6
On 2015/10/08 14:19:38, philipj_slow wrote:
> Please ignore if it's a WIP.
> 
>
https://codereview.chromium.org/1375153006/diff/20001/third_party/WebKit/Sour...
> File third_party/WebKit/Source/core/dom/Node.cpp (right):
> 
>
https://codereview.chromium.org/1375153006/diff/20001/third_party/WebKit/Sour...
> third_party/WebKit/Source/core/dom/Node.cpp:535: insertBefore(node.release(),
> firstChild(), exceptionState);
> Why have you added .release() here and elsewhere?

Landed https://codereview.chromium.org/1934123002. Closing this cl.

Powered by Google App Engine
This is Rietveld 408576698