Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(146)

Issue 1375083002: Mandoline: html_frame returns WebNavigationPolicyHandledByClient to blink when the navigation reque… (Closed)

Created:
5 years, 2 months ago by yzshen1
Modified:
5 years, 2 months ago
Reviewers:
sky
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Mandoline: html_frame returns WebNavigationPolicyHandledByClient to blink when the navigation request needs to go to the frame server side. This prevents prematurely dispatching load event. BUG= Committed: https://crrev.com/ee85199cb5a7b38dc57abe4fb962d1017410bf1b Cr-Commit-Position: refs/heads/master@{#351459}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+39 lines, -4 lines) Patch
M components/html_viewer/html_document.cc View 1 chunk +1 line, -1 line 0 comments Download
M components/html_viewer/html_frame.h View 3 chunks +7 lines, -0 lines 0 comments Download
M components/html_viewer/html_frame.cc View 4 chunks +31 lines, -3 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
yzshen1
Hi, Scott. Would you please take a look? Thanks!
5 years, 2 months ago (2015-09-29 20:41:50 UTC) #2
sky
LGTM
5 years, 2 months ago (2015-09-29 22:23:03 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1375083002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1375083002/1
5 years, 2 months ago (2015-09-30 00:36:33 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 2 months ago (2015-09-30 01:00:42 UTC) #6
commit-bot: I haz the power
5 years, 2 months ago (2015-09-30 01:02:44 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/ee85199cb5a7b38dc57abe4fb962d1017410bf1b
Cr-Commit-Position: refs/heads/master@{#351459}

Powered by Google App Engine
This is Rietveld 408576698