Issue 137503002: Make WebRtcLoggingHandlerHost tolerant of out-of-order messages.

Issue 137503002: Make WebRtcLoggingHandlerHost tolerant of out-of-order messages. (Closed)

Created:
6 years, 11 months ago by Tom Sepez

Modified:
6 years, 11 months ago

Reviewers:
tommi (sloooow) - chröme

CC:
chromium-reviews, fischman+watch_chromium.org, feature-media-reviews_chromium.org, wjia+watch_chromium.org, mcasas+watch_chromium.org, grunell (dont use)

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Make WebRtcLoggingHandlerHost tolerant of out-of-order messages. This avoids invoking a null callback when an untrusted renderer sends an out-of-sequence message. BUG=334038 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=245119

Patch Set 1 #

Total comments: 1

Patch Set 2 : Log bad state values. #

Patch Set 3 : 500s #

Created: 6 years, 11 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+8 lines, -0 lines)			Patch
	M	chrome/browser/media/webrtc_logging_handler_host.cc	View	1	1 chunk	+8 lines, -0 lines	0 comments	Download

Messages

Total messages: 7 (0 generated)

Expand Messages | Collapse Messages

tommi (sloooow) - chröme

lgtm https://codereview.chromium.org/137503002/diff/1/chrome/browser/media/webrtc_logging_handler_host.cc File chrome/browser/media/webrtc_logging_handler_host.cc (right): https://codereview.chromium.org/137503002/diff/1/chrome/browser/media/webrtc_logging_handler_host.cc#newcode225 chrome/browser/media/webrtc_logging_handler_host.cc:225: BadMessageReceived(); perhaps log an error and the current ...

6 years, 11 months ago (2014-01-14 15:14:22 UTC) #2

Tom Sepez

> perhaps log an error and the current value of logging_state_? Seems reasonable for a ...

6 years, 11 months ago (2014-01-14 19:01:04 UTC) #3

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tsepez@chromium.org/137503002/140001

6 years, 11 months ago (2014-01-14 19:32:21 UTC) #4

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tsepez@chromium.org/137503002/140001

6 years, 11 months ago (2014-01-14 23:29:13 UTC) #5

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tsepez@chromium.org/137503002/140001

6 years, 11 months ago (2014-01-15 03:35:30 UTC) #6

Message was sent while issue was closed.

Change committed as 245119

Expand Messages | Collapse Messages