Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(266)

Unified Diff: tools/gn/target_generator.cc

Issue 1375023003: tools/gn: Remove code for forward_dependent_configs_from variable. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: forward_dependent_configs Created 5 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: tools/gn/target_generator.cc
diff --git a/tools/gn/target_generator.cc b/tools/gn/target_generator.cc
index 833b382e274147275463fa4b3cbc2577359c6ec8..366210c6de4e48f85576af5a9e2e87e5de96a4fb 100644
--- a/tools/gn/target_generator.cc
+++ b/tools/gn/target_generator.cc
@@ -247,10 +247,6 @@ bool TargetGenerator::FillDependencies() {
return false;
}
- // This is a list of dependent targets to have their configs fowarded, so
- // it goes here rather than in FillConfigs.
- if (!FillForwardDependentConfigs())
- return false;
return true;
}
@@ -359,14 +355,3 @@ bool TargetGenerator::FillGenericDeps(const char* var_name,
}
return !err_->has_error();
}
-
-bool TargetGenerator::FillForwardDependentConfigs() {
- const Value* value = scope_->GetValue(
- variables::kForwardDependentConfigsFrom, true);
- if (value) {
- ExtractListOfUniqueLabels(*value, scope_->GetSourceDir(),
- ToolchainLabelForScope(scope_),
- &target_->forward_dependent_configs(), err_);
- }
- return !err_->has_error();
-}

Powered by Google App Engine
This is Rietveld 408576698