Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(78)

Unified Diff: tools/gn/builder.cc

Issue 1375023003: tools/gn: Remove code for forward_dependent_configs_from variable. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | tools/gn/command_desc.cc » ('j') | tools/gn/target_unittest.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools/gn/builder.cc
diff --git a/tools/gn/builder.cc b/tools/gn/builder.cc
index ca11e888d353bd3d6c5168afe09580103711fab8..25f6893cc18f1b68ff44aa843a572831a68ef831 100644
--- a/tools/gn/builder.cc
+++ b/tools/gn/builder.cc
@@ -495,15 +495,6 @@ bool Builder::ResolveForwardDependentConfigs(Target* target, Err* err) {
break;
}
}
- if (!config.ptr) {
- *err = Err(target->defined_from(),
- "Target in forward_dependent_configs_from was not listed in the deps",
- "This target has a forward_dependent_configs_from entry that was "
- "not present in\nthe deps. A target can only forward things it "
- "depends on. It was forwarding:\n " +
- config.label.GetUserVisibleName(false));
- return false;
- }
}
return true;
}
« no previous file with comments | « no previous file | tools/gn/command_desc.cc » ('j') | tools/gn/target_unittest.cc » ('J')

Powered by Google App Engine
This is Rietveld 408576698