Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(96)

Side by Side Diff: tools/gn/variables.cc

Issue 1375023003: tools/gn: Remove code for forward_dependent_configs_from variable. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: forward_dependent_configs Created 5 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« tools/gn/target_unittest.cc ('K') | « tools/gn/variables.h ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2013 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2013 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "tools/gn/variables.h" 5 #include "tools/gn/variables.h"
6 6
7 namespace variables { 7 namespace variables {
8 8
9 // Built-in variables ---------------------------------------------------------- 9 // Built-in variables ----------------------------------------------------------
10 10
(...skipping 713 matching lines...) Expand 10 before | Expand all | Expand 10 after
724 "\n" 724 "\n"
725 " Specifies private dependencies of a target. Shared and dynamic\n" 725 " Specifies private dependencies of a target. Shared and dynamic\n"
726 " libraries will be linked into the current target.\n" 726 " libraries will be linked into the current target.\n"
727 "\n" 727 "\n"
728 " These dependencies are private in that it does not grant dependent\n" 728 " These dependencies are private in that it does not grant dependent\n"
729 " targets the ability to include headers from the dependency, and direct\n" 729 " targets the ability to include headers from the dependency, and direct\n"
730 " dependent configs are not forwarded.\n" 730 " dependent configs are not forwarded.\n"
731 "\n" 731 "\n"
732 " See also \"public_deps\" and \"data_deps\".\n"; 732 " See also \"public_deps\" and \"data_deps\".\n";
733 733
734 // TODO(brettw) remove this, deprecated.
735 const char kForwardDependentConfigsFrom[] = "forward_dependent_configs_from";
736 const char kForwardDependentConfigsFrom_HelpShort[] =
737 "forward_dependent_configs_from: [label list] DEPRECATED.";
738 const char kForwardDependentConfigsFrom_Help[] =
739 "forward_dependent_configs_from\n"
740 "\n"
741 " A list of target labels.\n"
742 "\n"
743 " DEPRECATED. Use public_deps instead which will have the same effect.\n"
744 "\n"
745 " Exposes the public_configs from a private dependent target as\n"
746 " public_configs of the current one. Each label in this list\n"
747 " must also be in the deps.\n"
748 "\n"
749 " Generally you should use public_deps instead of this variable to\n"
750 " express the concept of exposing a dependency as part of a target's\n"
751 " public API. We're considering removing this variable.\n"
752 "\n"
753 "Discussion\n"
754 "\n"
755 " Sometimes you depend on a child library that exports some necessary\n"
756 " configuration via public_configs. If your target in turn exposes the\n"
757 " child library's headers in its public headers, it might mean that\n"
758 " targets that depend on you won't work: they'll be seeing the child\n"
759 " library's code but not the necessary configuration. This list\n"
760 " specifies which of your deps' direct dependent configs to expose as\n"
761 " your own.\n"
762 "\n"
763 "Examples\n"
764 "\n"
765 " If we use a given library \"a\" from our public headers:\n"
766 "\n"
767 " deps = [ \":a\", \":b\", ... ]\n"
768 " forward_dependent_configs_from = [ \":a\" ]\n"
769 "\n"
770 " This example makes a \"transparent\" target that forwards a dependency\n"
771 " to another:\n"
772 "\n"
773 " group(\"frob\") {\n"
774 " if (use_system_frob) {\n"
775 " deps = \":system_frob\"\n"
776 " } else {\n"
777 " deps = \"//third_party/fallback_frob\"\n"
778 " }\n"
779 " forward_dependent_configs_from = deps\n"
780 " }\n";
781
782 const char kIncludeDirs[] = "include_dirs"; 734 const char kIncludeDirs[] = "include_dirs";
783 const char kIncludeDirs_HelpShort[] = 735 const char kIncludeDirs_HelpShort[] =
784 "include_dirs: [directory list] Additional include directories."; 736 "include_dirs: [directory list] Additional include directories.";
785 const char kIncludeDirs_Help[] = 737 const char kIncludeDirs_Help[] =
786 "include_dirs: Additional include directories.\n" 738 "include_dirs: Additional include directories.\n"
787 "\n" 739 "\n"
788 " A list of source directories.\n" 740 " A list of source directories.\n"
789 "\n" 741 "\n"
790 " The directories in this list will be added to the include path for\n" 742 " The directories in this list will be added to the include path for\n"
791 " the files in the affected target.\n" 743 " the files in the affected target.\n"
(...skipping 594 matching lines...) Expand 10 before | Expand all | Expand 10 after
1386 INSERT_VARIABLE(CflagsObjCC) 1338 INSERT_VARIABLE(CflagsObjCC)
1387 INSERT_VARIABLE(CheckIncludes) 1339 INSERT_VARIABLE(CheckIncludes)
1388 INSERT_VARIABLE(CompleteStaticLib) 1340 INSERT_VARIABLE(CompleteStaticLib)
1389 INSERT_VARIABLE(Configs) 1341 INSERT_VARIABLE(Configs)
1390 INSERT_VARIABLE(Console) 1342 INSERT_VARIABLE(Console)
1391 INSERT_VARIABLE(Data) 1343 INSERT_VARIABLE(Data)
1392 INSERT_VARIABLE(DataDeps) 1344 INSERT_VARIABLE(DataDeps)
1393 INSERT_VARIABLE(Defines) 1345 INSERT_VARIABLE(Defines)
1394 INSERT_VARIABLE(Depfile) 1346 INSERT_VARIABLE(Depfile)
1395 INSERT_VARIABLE(Deps) 1347 INSERT_VARIABLE(Deps)
1396 INSERT_VARIABLE(ForwardDependentConfigsFrom)
1397 INSERT_VARIABLE(IncludeDirs) 1348 INSERT_VARIABLE(IncludeDirs)
1398 INSERT_VARIABLE(Inputs) 1349 INSERT_VARIABLE(Inputs)
1399 INSERT_VARIABLE(Ldflags) 1350 INSERT_VARIABLE(Ldflags)
1400 INSERT_VARIABLE(Libs) 1351 INSERT_VARIABLE(Libs)
1401 INSERT_VARIABLE(LibDirs) 1352 INSERT_VARIABLE(LibDirs)
1402 INSERT_VARIABLE(OutputExtension) 1353 INSERT_VARIABLE(OutputExtension)
1403 INSERT_VARIABLE(OutputName) 1354 INSERT_VARIABLE(OutputName)
1404 INSERT_VARIABLE(Outputs) 1355 INSERT_VARIABLE(Outputs)
1405 INSERT_VARIABLE(PrecompiledHeader) 1356 INSERT_VARIABLE(PrecompiledHeader)
1406 INSERT_VARIABLE(PrecompiledSource) 1357 INSERT_VARIABLE(PrecompiledSource)
1407 INSERT_VARIABLE(Public) 1358 INSERT_VARIABLE(Public)
1408 INSERT_VARIABLE(PublicConfigs) 1359 INSERT_VARIABLE(PublicConfigs)
1409 INSERT_VARIABLE(PublicDeps) 1360 INSERT_VARIABLE(PublicDeps)
1410 INSERT_VARIABLE(Script) 1361 INSERT_VARIABLE(Script)
1411 INSERT_VARIABLE(Sources) 1362 INSERT_VARIABLE(Sources)
1412 INSERT_VARIABLE(Testonly) 1363 INSERT_VARIABLE(Testonly)
1413 INSERT_VARIABLE(Visibility) 1364 INSERT_VARIABLE(Visibility)
1414 } 1365 }
1415 return info_map; 1366 return info_map;
1416 } 1367 }
1417 1368
1418 #undef INSERT_VARIABLE 1369 #undef INSERT_VARIABLE
1419 1370
1420 } // namespace variables 1371 } // namespace variables
OLDNEW
« tools/gn/target_unittest.cc ('K') | « tools/gn/variables.h ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698