ios/web/web_state/js/crw_js_post_request_loader.h - Issue 1375023002: Adds support for POST request with bodies on WKWebView.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: ios/web/web_state/js/crw_js_post_request_loader.h

Issue 1375023002: Adds support for POST request with bodies on WKWebView. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: missing file Created 5 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

OLD	NEW
(Empty)
	1 // Copyright 2015 The Chromium Authors. All rights reserved.

	2 // Use of this source code is governed by a BSD-style license that can be

	3 // found in the LICENSE file.

	4

	5 #ifndef IOS_WEB_WEB_STATE_JS_CRW_JS_POST_REQUEST_LOADER_H_

	6 #define IOS_WEB_WEB_STATE_JS_CRW_JS_POST_REQUEST_LOADER_H_

	7

	8 #import <WebKit/WKWebView.h>
	Eugene But (OOO till 7-30) 2015/12/02 17:06:15 s/<WebKit/WKWebView.h>/<WebKit/WebKit.h> https:// s/<WebKit/WKWebView.h>/<WebKit/WebKit.h> https://google.github.io/styleguide/objcguide.xml?showone=Use_Root_Frameworks... stkhapugin 2015/12/03 15:43:01 Done. Show quoted text On 2015/12/02 17:06:15, eugenebut wrote: > s/<WebKit/WKWebView.h>/<WebKit/WebKit.h> > > https://google.github.io/styleguide/objcguide.xml?showone=Use_Root_Frameworks... Done.
	9

	10 @class CRWWKScriptMessageRouter;

	11

	12 // Class to load POST requests in a provided web view via JavaScript.

	13 @interface CRWJSPOSTRequestLoader : NSObject

	14

	15 // Asynchronously loads a POST \|request\| in provided \|webView\|.

	16 // It temporarily installs JavaScript message routers with \|messageRouter\| to

	17 // handle HTTP errors. If an error occurs, \|errorBlock\| is called. If the load

	18 // was successfull, the optional \|successBlock\| is called.

	19 - (void)loadPOSTRequest:(NSURLRequest*)request

	20 inWebView:(WKWebView*)webView

	21 messageRouter:(CRWWKScriptMessageRouter*)messageRouter

	22 errorBlock:(void (^)(NSError*))errorBlock
	Eugene But (OOO till 7-30) 2015/12/02 17:06:15 There should be only one completion handler for bo There should be only one completion handler for both success and failure cases. For success case NSError is nil. - (void)loadPOSTRequest:(NSURLRequest)request .... completionHandler:(void (^)(NSError))completionHandler Having 2 blocks is error prone, lead to code duplication and makes formatting uglier. stkhapugin 2015/12/03 15:43:01 Done. Show quoted text On 2015/12/02 17:06:15, eugenebut wrote: > There should be only one completion handler for both success and failure cases. > For success case NSError is nil. > > - (void)loadPOSTRequest:(NSURLRequest)request > .... > completionHandler:(void (^)(NSError))completionHandler > > Having 2 blocks is error prone, lead to code duplication and makes formatting > uglier. Done.
	23 successBlock:(void (^)())successBlock;

	24

	25 @end

	26

	27 #endif // IOS_WEB_WEB_STATE_JS_CRW_JS_POST_REQUEST_LOADER_H_

OLD	NEW