Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(92)

Side by Side Diff: ios/web/web_state/js/resources/post_request.js

Issue 1375023002: Adds support for POST request with bodies on WKWebView. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: rest of the commetns Created 5 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
(Empty)
1 // Copyright 2015 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file.
4
5 // Provides a way to implement POST requests via XMLHttpRequest.
6 // Works around https://bugs.webkit.org/show_bug.cgi?id=145410 on WKWebView.
7
8 'use strict';
9
10 goog.provide('__crPOSTRequestHack');
Eugene But (OOO till 7-30) 2015/10/08 17:46:32 s/__crPOSTRequestHack/__crWeb.postRequestHack
stkhapugin 2015/12/03 15:43:01 Done.
11
12 /**
13 * Namespace for this file.
14 */
15 __crPOSTRequestHack = {};
Eugene But (OOO till 7-30) 2015/10/08 17:46:32 __crPostRequestHack According to JS Style Guide a
stkhapugin 2015/12/03 15:43:01 Done.
16
17 /**
18 * Executes a POST request with given parameters and replaces document body with
19 * the response.
20 * @param {string} url The url of the request.
21 * @param {Object<string,string>} headers Request headers to include in POST.
22 * Each header value must be expressed as a key-value pair in this object.
23 * @param {string} base64Data Request body encoded with Base64.
24 * @param {string} contentType Content-Type header value.
25 */
26 __crPOSTRequestHack.runPOSTRequest = function(url, headers, base64Data,
Eugene But (OOO till 7-30) 2015/10/08 17:46:32 NIT: s/base64Data/body this way we can keep consis
stkhapugin 2015/12/03 15:43:01 Done.
27 contentType) {
28
29 /**
30 * Converts a Base64-encoded string to a blob.
31 * @param {string} byteCharacters Base64-encoded data string.
32 * @param {string} contentType Corresponding content type.
33 * @return {Blob} Binary representation of byteCharacters.
34 */
35 var base64ToBlob = function(byteCharacters, contentType) {
36 contentType = contentType || '';
37 var sliceSize = 512;
38 var byteArrays = [];
39 for (var offset = 0; offset < byteCharacters.length; offset += sliceSize){
40 var slice = byteCharacters.slice(offset, offset + sliceSize);
41 var byteNumbers = new Array(slice.length);
42 for (var i = 0; i < slice.length; i++) {
43 byteNumbers[i] = slice.charCodeAt(i);
44 }
45 var byteArray = new Uint8Array(byteNumbers);
46 byteArrays.push(byteArray);
47 }
48 var blob = new Blob(byteArrays, {type: contentType});
49 return blob;
50 }
51
52 /**
53 * Creates and executes a POST request.
54 * @param {string} url The url of the request.
55 * @param {Object<string,string>} headers Request headers to include in POST.
56 * Each header value must be expressed as a key-value pair in this object.
57 * @param {string} b64Data Request body encoded with Base64.
58 * @param {string} contentType Content-Type header value.
59 */
60 var createAndSendPOSTRequest = function(url, headers, b64Data, contentType){
Eugene But (OOO till 7-30) 2015/10/08 17:46:32 createAndSendPostRequest
Eugene But (OOO till 7-30) 2015/10/08 17:46:32 NIT: s/b64Data/body
stkhapugin 2015/12/03 15:43:01 Done.
stkhapugin 2015/12/03 15:43:01 Done.
61 var request = new XMLHttpRequest();
62 request.open('POST', url, false);
63 for (var key in headers) {
64 request.setRequestHeader(key, headers[key]);
Eugene But (OOO till 7-30) 2015/10/08 17:46:32 You want to make hasOwnProperty check, otherwise y
stkhapugin 2015/12/03 15:43:01 Done.
65 }
66 var blob = base64ToBlob(atob(b64Data), contentType);
67 request.send(blob);
68 if (request.status != 200) {
69 throw request.status;
stuartmorgan 2015/10/08 19:11:29 Why are we throwing a JS exception for non-200 sta
stkhapugin 2015/12/03 15:43:01 I added an error handler that catches any non-200
70 }
71 return request.responseText;
72 }
73
74 document.open();
75 document.write(createAndSendPOSTRequest(url, headers, base64Data,
Eugene But (OOO till 7-30) 2015/10/08 17:46:32 document.write reinjects our scripts w/o giving us
stkhapugin 2015/12/03 15:43:01 Done.
76 contentType));
77 document.close();
78 }
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698