src/runtime/runtime-array.cc - Issue 1375003002: Teach JSReceiver::GetKeys() how to include symbols

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/runtime/runtime-array.cc

Issue 1375003002: Teach JSReceiver::GetKeys() how to include symbols (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master

Patch Set: rebased Created 5 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: src/runtime/runtime-array.cc

diff --git a/src/runtime/runtime-array.cc b/src/runtime/runtime-array.cc

index 6fc1ad4ea12e371438792c4afdae058833ac6189..d2f04c97624dab44fe60b36a1916f204221b4487 100644

--- a/src/runtime/runtime-array.cc

+++ b/src/runtime/runtime-array.cc

@@ -220,7 +220,7 @@ RUNTIME_FUNCTION(Runtime_GetArrayKeys) {

Handle<FixedArray> current_keys =

isolate->factory()->NewFixedArray(current->NumberOfOwnElements(NONE));

current->GetOwnElementKeys(*current_keys, NONE);

- accumulator.AddKeys(current_keys, FixedArray::ALL_KEYS);

+ accumulator.AddKeys(current_keys, INCLUDE_SYMBOLS);

}

// Erase any keys >= length.

// TODO(adamk): Remove this step when the contract of %GetArrayKeys

« no previous file with comments | « src/objects.cc ('k') | no next file » | no next file with comments »